From patchwork Wed Jan 31 18:09:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10194407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5A10D60380 for ; Wed, 31 Jan 2018 18:15:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 378AA287F8 for ; Wed, 31 Jan 2018 18:15:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B370287FB; Wed, 31 Jan 2018 18:15:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABEB5287F8 for ; Wed, 31 Jan 2018 18:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754031AbeAaSOa (ORCPT ); Wed, 31 Jan 2018 13:14:30 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36386 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbeAaSJy (ORCPT ); Wed, 31 Jan 2018 13:09:54 -0500 Received: by mail-wr0-f194.google.com with SMTP id y3so6187427wrh.3 for ; Wed, 31 Jan 2018 10:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XoCwyv3z7MI/oYAqi2dpM7HJlI5GXUwayYtCQqMMLwE=; b=YwFEPemcnVscz36PXu16HOhTSp57QalI1ewgSQ7mCWpSbG8qeNhK2FTHs/hHkLOqfF q9I1ZuSw+wlY/zKJvIIKm8NLnbRJ8akCSUBH1qQZ6P5q+syLergKiGgino8YAV1OOusl 1Uqax4hMw80nb/meahV/LG5ajINZqPTMPHhTd5n/1JjKOjUhJq2BONbP08QDvAIEVW7u 1iC6Jxrx7k+1J5l2nm2mmHd6Cqi9gAnRclWvFVBkgOOSUdNnrkl+uD50+c4fFlGkgoV0 IwG31l9Geqr8UivTgCZAuaEJ78CZUL+huMz/5S43KXB4+EbIvh8fOH12mwc0bU1Vu1kp 723g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XoCwyv3z7MI/oYAqi2dpM7HJlI5GXUwayYtCQqMMLwE=; b=YbeDDJs9TAJ0xe1ESiEPy2aLHQFMDfVzei2sj/fj1PloCkxwi4fxjjrAE5PaOFrUbe jY4jPs9pmU+7n74JJPR582V9F4FoM6ZMkgQYx7pZght5GyEfxfq8rYcn7U5QPj61T+lk xSgFZjRg5v0XKohuwBLlg9lL3NwUYj29AGFVWAsEoqnhr3ynWlU/yODNbAo4R6hDY4rL GtH105dxFgVQkq6krp6nZdeV1d0P4qa63FAFPBzH3XJHKtyMvdG7Z9PUEHs1hpAHSjx7 68MOT5N8g7wf9uNsbGTfQc7HPMo5clkfi8bu74S42If0aW6RZh41JO3OptlXnvMflg6r zSRQ== X-Gm-Message-State: AKwxytcXoR9hP02ah8y8i8a17xfbEUsjdT4ZiF0kvPF7DDSSvZ1yhgId UQ/Qvsq1qsBBdOMPbZRMKFDsBw== X-Google-Smtp-Source: AH8x227fhbAs0Yq8u4I4nUA3QTTaEU1ISOONVUn4EJPf/hf5y+awwDjhXtMCo621jx/P+o9nNzkHMQ== X-Received: by 10.223.173.119 with SMTP id p110mr16001416wrc.69.1517422193522; Wed, 31 Jan 2018 10:09:53 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id f8sm341977wmc.3.2018.01.31.10.09.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jan 2018 10:09:53 -0800 (PST) From: Jerome Brunet To: Neil Armstrong , Kevin Hilman Cc: Jerome Brunet , Stephen Boyd , Michael Turquette , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/19] clk: meson: remove obsolete comments Date: Wed, 31 Jan 2018 19:09:30 +0100 Message-Id: <20180131180945.18025-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180131180945.18025-1-jbrunet@baylibre.com> References: <20180131180945.18025-1-jbrunet@baylibre.com> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Over time things changes in CCF and issues have been fixed in meson controllers. Now, clk81 is decently modeled by read-only PLLs, a mux, a divider and a gate. We can remove the FIXME comments related to clk81. Also remove the comment about devm_clk_hw_register, as there is apparently nothing wrong with it. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 5 ----- drivers/clk/meson/gxbb.c | 6 ------ drivers/clk/meson/meson8b.c | 1 - 3 files changed, 12 deletions(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 81565b025b70..f84927e76f88 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -411,11 +411,6 @@ static struct meson_clk_mpll axg_mpll3 = { }, }; -/* - * FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers - * and should be modeled with their respective PLLs via the forthcoming - * coordinated clock rates feature - */ static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index e6adab49c0ba..6609024eee00 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -575,12 +575,6 @@ static struct meson_clk_mpll gxbb_mpll2 = { }, }; -/* - * FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers - * and should be modeled with their respective PLLs via the forthcoming - * coordinated clock rates feature - */ - static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index ffadad27375e..db017c29a84c 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -849,7 +849,6 @@ static int meson8b_clkc_probe(struct platform_device *pdev) if (!meson8b_hw_onecell_data.hws[i]) continue; - /* FIXME convert to devm_clk_register */ ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[i]); if (ret) return ret;