From patchwork Sat Jun 2 13:12:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 10444841 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F038860375 for ; Sat, 2 Jun 2018 13:13:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C6E6028A14 for ; Sat, 2 Jun 2018 13:13:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B287A28A0C; Sat, 2 Jun 2018 13:13:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7442528979 for ; Sat, 2 Jun 2018 13:12:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750844AbeFBNM6 (ORCPT ); Sat, 2 Jun 2018 09:12:58 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:59441 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbeFBNMz (ORCPT ); Sat, 2 Jun 2018 09:12:55 -0400 Received: from penelope.horms.nl (unknown [50.234.174.228]) by kirsty.vergenet.net (Postfix) with ESMTPA id 9143525B77D; Sat, 2 Jun 2018 23:12:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1527945173; bh=2dapP6aK48LL7wZcNKnF1nX0S1PDZA8rAfuxEv8gJDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pTqztUwXKxr/zBHA2TZGgbuE8LC+JWHascEArDUzqGFx03YkbpVjnRcyCorMbl4NT n0HsVCtUqt3Bbsq+kF1Ak59uJOEDTppDgHyMPpMQIrdny1FKaQjPK/ZR7PDXwje+Y2 XyL7bo0eXA56xCb46c8raM6VsWAOkZHEUewWVV7U= Received: by penelope.horms.nl (Postfix, from userid 7100) id B87E8E224F9; Sat, 2 Jun 2018 15:12:45 +0200 (CEST) Date: Sat, 2 Jun 2018 09:12:45 -0400 From: Simon Horman To: Geert Uytterhoeven Cc: Gilad Ben-Yossef , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Herbert Xu , "David S. Miller" , Ofir Drang , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux kernel mailing list , linux-clk , Linux Crypto Mailing List Subject: Re: [PATCH v2 5/5] arm64: dts: renesas: r8a7795: add ccree binding Message-ID: <20180602131241.5cl4hkbxydvcy6mu@verge.net.au> References: <1527171551-21979-1-git-send-email-gilad@benyossef.com> <1527171551-21979-6-git-send-email-gilad@benyossef.com> <20180529161936.prhp4oikzamr6u3n@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Jun 01, 2018 at 10:12:24AM +0200, Geert Uytterhoeven wrote: > Hi Gilad, > > On Thu, May 31, 2018 at 1:55 PM, Gilad Ben-Yossef wrote: > > On Tue, May 29, 2018 at 7:19 PM, Simon Horman wrote: > >> On Thu, May 24, 2018 at 03:19:10PM +0100, Gilad Ben-Yossef wrote: > >>> Add bindings for CryptoCell instance in the SoC. > >>> > >>> Signed-off-by: Gilad Ben-Yossef > >> > >> In so far as I can review the details of this (which is not much) this > >> looks fine to me. I am, however, a little unclear in when it should be > >> accepted. > > > > Since Herbert Xu ACKed the driver changes, I would say the only gating > > commit is Geert's CR clock patch. > > These are queued for v4.19. > > > If that one is in, than I would say this one should go in as well. > > As the device node now has a power-domains property, the genpd code will > try to attach it to the CPG/MSSR PM Domain, which is a clock domain. > In the absence of the clock patch, the device's module clock cannot be > found, and dev_pm_domain_attach() and thus platform_drv_probe() will fail, > before calling the device driver's .probe() function. > > So there is no longer a dependency on the clock patch, and the DT patch can > go in in parallel (although I prefer its subject to be changed > s/binding/device device/). Thanks, I have applied the following (but may not push until next week). From: Gilad Ben-Yossef Subject: [PATCH] arm64: dts: renesas: r8a7795: add ccree to device tree Add bindings for CryptoCell instance in the SoC. Signed-off-by: Gilad Ben-Yossef Reviewed-by: Geert Uytterhoeven Signed-off-by: Simon Horman --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index d842940b2f43..3ac75dbf2d93 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -528,6 +528,15 @@ status = "disabled"; }; + arm_cc630p: crypto@e6601000 { + compatible = "arm,cryptocell-630p-ree"; + interrupts = ; + reg = <0x0 0xe6601000 0 0x1000>; + clocks = <&cpg CPG_MOD 229>; + resets = <&cpg 229>; + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; + }; + i2c3: i2c@e66d0000 { #address-cells = <1>; #size-cells = <0>;