[4.14,18/36] serial: sh-sci: Stop using printk format %pCr

Commit Message

Greg KH June 14, 2018, 2:04 p.m. UTC

4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Geert Uytterhoeven <[e-mail]>

commit d63c16f8e1ab761775275adcf54f4bef7c330295 upstream.

Printk format "%pCr" will be removed soon, as clk_get_rate() must not be
called in atomic context.

Replace it by open-coding the operation.  This is safe here, as the code
runs in task context.

Link: http://lkml.kernel.org/r/[e-mail]
To: Jia-Ju Bai <[e-mail]>
To: Jonathan Corbet <[e-mail]>
To: Michael Turquette <[e-mail]>
To: Stephen Boyd <[e-mail]>
To: Zhang Rui <[e-mail]>
To: Eduardo Valentin <[e-mail]>
To: Eric Anholt <[e-mail]>
To: Stefan Wahren <[e-mail]>
To: Greg Kroah-Hartman <[e-mail]>
Cc: Sergey Senozhatsky <[e-mail]>
Cc: Petr Mladek <[e-mail]>
Cc: Linus Torvalds <[e-mail]>
Cc: Steven Rostedt <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: Geert Uytterhoeven <[e-mail]>
Cc: [e-mail] # 4.5+
Signed-off-by: Geert Uytterhoeven <[e-mail]>
Signed-off-by: Petr Mladek <[e-mail]>
Signed-off-by: Greg Kroah-Hartman <[e-mail]>

---
 drivers/tty/serial/sh-sci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2669,8 +2669,8 @@  found:
 			dev_dbg(dev, "failed to get %s (%ld)\n", clk_names[i],
 				PTR_ERR(clk));
 		else
-			dev_dbg(dev, "clk %s is %pC rate %pCr\n", clk_names[i],
-				clk, clk);
+			dev_dbg(dev, "clk %s is %pC rate %lu\n", clk_names[i],
+				clk, clk_get_rate(clk));
 		sci_port->clks[i] = IS_ERR(clk) ? NULL : clk;
 	}
 	return 0;