From patchwork Tue Mar 19 09:31:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 10859203 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3216A139A for ; Tue, 19 Mar 2019 09:32:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 190A72958F for ; Tue, 19 Mar 2019 09:32:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0710D295AF; Tue, 19 Mar 2019 09:32:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F3972958F for ; Tue, 19 Mar 2019 09:32:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725862AbfCSJcF (ORCPT ); Tue, 19 Mar 2019 05:32:05 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:33836 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbfCSJcC (ORCPT ); Tue, 19 Mar 2019 05:32:02 -0400 Received: by mail-ot1-f67.google.com with SMTP id r19so17087132otn.1 for ; Tue, 19 Mar 2019 02:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=iqS0mD2DkpD+ki4OIwDG5Tufv1Vltf3JG5TtzYwAJaQ=; b=IQDjPx98/it3WTI1P1wn4ptXAPDKpO99H8tMiZ5yS0rw6fQtDerjKjLOVE3OcB6/H7 Y0hsSPTXZHutkEpWqLyt6pPWK7DlGrVwlQAIVFY4qle4XiMCen64rfv/kAheuvIi/KsH T/yq07jkbU1nPaLUtuV+QgZ1WSQoR1tFZX9VKdi7L62nuhBZUvwHnPfEW/f4ozg+z16k ZgaHhoEsmsR4qMEBi1ieBFuSfFytN/1ObzcyQtt2Y1TeUbCiEX/DJD0BO3B39++nIj6n iD6khJ4zb4g2GbBuWfilu9iMpvKBEIEN/9tip+Nu6SgdEgkxSdLhYo5O+4E+/i7EmLkl Cy0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iqS0mD2DkpD+ki4OIwDG5Tufv1Vltf3JG5TtzYwAJaQ=; b=ga+WJWkPgYTmE3B/Mo8NwO4KZ0YiX/9+RRWLa0r0kn8FDMHhTAY5sceGEJR71Qn18u EuaJqmEib90o5qQTaGoM1wiW6JZ6CNWft0yTc3pzf4DUp7OyeeMpkNfzotHqau7Z0RUD UdY82qamrQcHC6jG8rRTrTiQk9jvj1eeydSu59zOML3sq/e8rMkabV3jqVylGSOSxVhf Z0Ux9JtgYdJdJy/a+/65REt8hXBgvD7wMo4GyOxID08nTPDhZS5NctU/sseYOHFtrL0U Sp7RYbKgWbCKRs6O4h+DLA1PdUDKoRYZzVDljzhgzqcVe5HkaQuxNuow9DMcG1gyjz5B MQvQ== X-Gm-Message-State: APjAAAVwiAUXvYO8bRVsNfBlidTQjuA/cLf9pT8uRix3GNwOaJ5Wc8CC UrGtZ9f4HntD3KjXtnLEG62vzw== X-Google-Smtp-Source: APXvYqywx0YgPF/s2pgrbZCRIsLrGu21OCrcWPMSUAsmF007QCmybINk51gyABh1Y2urb14uMvFM7A== X-Received: by 2002:a9d:6857:: with SMTP id c23mr923448oto.62.1552987921852; Tue, 19 Mar 2019 02:32:01 -0700 (PDT) Received: from localhost.localdomain (li808-42.members.linode.com. [104.237.132.42]) by smtp.gmail.com with ESMTPSA id n12sm4864065otl.22.2019.03.19.02.31.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 02:32:01 -0700 (PDT) From: Leo Yan To: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , stable@vger.kernel.org, Zhong Kaihua , John Stultz , Zhangfei Gao Subject: [RESEND PATCH] clk: hi3660: Mark clk_gate_ufs_subsys as critical Date: Tue, 19 Mar 2019 17:31:48 +0800 Message-Id: <20190319093148.1909-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP clk_gate_ufs_subsys is a system bus clock, turning off it will introduce lockup issue during system suspend flow. Let's mark clk_gate_ufs_subsys as critical clock, thus keeps it on during system suspend and resume. Fixes: d374e6fd5088 ("clk: hisilicon: Add clock driver for hi3660 SoC") Cc: stable@vger.kernel.org Cc: Zhong Kaihua Cc: John Stultz Cc: Zhangfei Gao Suggested-by: Dong Zhang Signed-off-by: Leo Yan --- drivers/clk/hisilicon/clk-hi3660.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/hisilicon/clk-hi3660.c b/drivers/clk/hisilicon/clk-hi3660.c index f40419959656..32ba80181cc6 100644 --- a/drivers/clk/hisilicon/clk-hi3660.c +++ b/drivers/clk/hisilicon/clk-hi3660.c @@ -164,7 +164,7 @@ static const struct hisi_gate_clock hi3660_crgctrl_gate_sep_clks[] = { { HI3660_CLK_GATE_ISP_SNCLK2, "clk_gate_isp_snclk2", "clk_isp_snclk_mux", CLK_SET_RATE_PARENT, 0x50, 18, 0, }, { HI3660_CLK_GATE_UFS_SUBSYS, "clk_gate_ufs_subsys", "clk_div_sysbus", - CLK_SET_RATE_PARENT, 0x50, 21, 0, }, + CLK_SET_RATE_PARENT|CLK_IS_CRITICAL, 0x50, 21, 0, }, { HI3660_PCLK_GATE_DSI0, "pclk_gate_dsi0", "clk_div_cfgbus", CLK_SET_RATE_PARENT, 0x50, 28, 0, }, { HI3660_PCLK_GATE_DSI1, "pclk_gate_dsi1", "clk_div_cfgbus",