diff mbox series

clk: ingenic: Remove OF_POPULATED flag to probe children

Message ID 20190714215715.11412-1-paul@crapouillou.net (mailing list archive)
State Changes Requested, archived
Headers show
Series clk: ingenic: Remove OF_POPULATED flag to probe children | expand

Commit Message

Paul Cercueil July 14, 2019, 9:57 p.m. UTC
Remove the OF_POPULATED flag, in order to probe children when the
device node is compatible with "simple-mfd".

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/clk/ingenic/cgu.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stephen Boyd July 16, 2019, 4:48 p.m. UTC | #1
Quoting Paul Cercueil (2019-07-14 14:57:15)
> Remove the OF_POPULATED flag, in order to probe children when the
> device node is compatible with "simple-mfd".

We have CLK_OF_DECLARE_DRIVER for this. Can you use that?

> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/clk/ingenic/cgu.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
Paul Cercueil July 16, 2019, 4:57 p.m. UTC | #2
Le mar. 16 juil. 2019 à 12:48, Stephen Boyd <sboyd@kernel.org> a 
écrit :
> Quoting Paul Cercueil (2019-07-14 14:57:15)
>>  Remove the OF_POPULATED flag, in order to probe children when the
>>  device node is compatible with "simple-mfd".
> 
> We have CLK_OF_DECLARE_DRIVER for this. Can you use that?

Didn't see it. I'll send an updated patch then, thanks.


>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>>   drivers/clk/ingenic/cgu.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
diff mbox series

Patch

diff --git a/drivers/clk/ingenic/cgu.c b/drivers/clk/ingenic/cgu.c
index 6e963031cd87..bf2a86cf1dbf 100644
--- a/drivers/clk/ingenic/cgu.c
+++ b/drivers/clk/ingenic/cgu.c
@@ -759,6 +759,12 @@  ingenic_cgu_new(const struct ingenic_cgu_clk_info *clock_info,
 
 	spin_lock_init(&cgu->lock);
 
+	/*
+	 * Remove the OF_POPULATED flag, in order to probe children when the
+	 * device node is compatible with "simple-mfd".
+	 */
+	of_node_clear_flag(np, OF_POPULATED);
+
 	return cgu;
 
 err_out_free: