diff mbox series

[1/6] clk: Sync prototypes for clk_bulk_enable()

Message ID 20190715201234.13556-1-andrew.smirnov@gmail.com (mailing list archive)
State Changes Requested, archived
Headers show
Series [1/6] clk: Sync prototypes for clk_bulk_enable() | expand

Commit Message

Andrey Smirnov July 15, 2019, 8:12 p.m. UTC 
No-op version of clk_bulk_enable() should have the same protoype as
the real implementation, so constify the last argument to make it so.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Chris Healy <cphealy@gmail.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 include/linux/clk.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Stephen Boyd July 15, 2019, 10 p.m. UTC | #1 
Quoting Andrey Smirnov (2019-07-15 13:12:29)
> No-op version of clk_bulk_enable() should have the same protoype as
> the real implementation, so constify the last argument to make it so.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---

No cover letter, but I'm inclined to squash these all together into one
patch instead of 6. I'm not sure why each function gets a different
patch.

>  include/linux/clk.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
Andrey Smirnov July 17, 2019, 2:53 p.m. UTC | #2 
On Mon, Jul 15, 2019 at 3:00 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Andrey Smirnov (2019-07-15 13:12:29)
> > No-op version of clk_bulk_enable() should have the same protoype as
> > the real implementation, so constify the last argument to make it so.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Russell King <linux@armlinux.org.uk>
> > Cc: Chris Healy <cphealy@gmail.com>
> > Cc: linux-clk@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
>
> No cover letter, but I'm inclined to squash these all together into one
> patch instead of 6. I'm not sure why each function gets a different
> patch.
>

Sure, will squash all in v2.

Thanks,
Andrey Smirnov
diff mbox series

Patch

diff --git a/include/linux/clk.h b/include/linux/clk.h
index 3c096c7a51dc..a35868ccc912 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -819,7 +819,8 @@  static inline int clk_enable(struct clk *clk)
 	return 0;
 }
 
-static inline int __must_check clk_bulk_enable(int num_clks, struct clk_bulk_data *clks)
+static inline int __must_check clk_bulk_enable(int num_clks,
+					       const struct clk_bulk_data *clks)
 {
 	return 0;
 }