diff mbox series

clk: ux500: Fix up the SGA clock for some variants

Message ID 20191217210504.27888-1-linus.walleij@linaro.org (mailing list archive)
State Accepted, archived
Headers show
Series clk: ux500: Fix up the SGA clock for some variants | expand

Commit Message

Linus Walleij Dec. 17, 2019, 9:05 p.m. UTC
Some of the special PRCMU firmware variants were not
properly detected in the Ux500 clock driver, resulting
in the wrong clock for the SGA.

Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/clk/ux500/u8500_of_clk.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ulf Hansson Dec. 18, 2019, 2:28 p.m. UTC | #1
On Tue, 17 Dec 2019 at 22:05, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Some of the special PRCMU firmware variants were not
> properly detected in the Ux500 clock driver, resulting
> in the wrong clock for the SGA.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
>  drivers/clk/ux500/u8500_of_clk.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
> index 72ed97c6662a..0aedd42fad52 100644
> --- a/drivers/clk/ux500/u8500_of_clk.c
> +++ b/drivers/clk/ux500/u8500_of_clk.c
> @@ -99,8 +99,10 @@ static void u8500_clk_init(struct device_node *np)
>         if (fw_version != NULL) {
>                 switch (fw_version->project) {
>                 case PRCMU_FW_PROJECT_U8500_C2:
> +               case PRCMU_FW_PROJECT_U8500_MBL:
>                 case PRCMU_FW_PROJECT_U8520:
>                 case PRCMU_FW_PROJECT_U8420:
> +               case PRCMU_FW_PROJECT_U8420_SYSCLK:
>                         sgaclk_parent = "soc0_pll";
>                         break;
>                 default:
> --
> 2.21.0
>
Stephan Gerhold Dec. 18, 2019, 6:50 p.m. UTC | #2
On Tue, Dec 17, 2019 at 10:05:04PM +0100, Linus Walleij wrote:
> Some of the special PRCMU firmware variants were not
> properly detected in the Ux500 clock driver, resulting
> in the wrong clock for the SGA.
> 
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

> ---
>  drivers/clk/ux500/u8500_of_clk.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
> index 72ed97c6662a..0aedd42fad52 100644
> --- a/drivers/clk/ux500/u8500_of_clk.c
> +++ b/drivers/clk/ux500/u8500_of_clk.c
> @@ -99,8 +99,10 @@ static void u8500_clk_init(struct device_node *np)
>  	if (fw_version != NULL) {
>  		switch (fw_version->project) {
>  		case PRCMU_FW_PROJECT_U8500_C2:
> +		case PRCMU_FW_PROJECT_U8500_MBL:
>  		case PRCMU_FW_PROJECT_U8520:
>  		case PRCMU_FW_PROJECT_U8420:
> +		case PRCMU_FW_PROJECT_U8420_SYSCLK:
>  			sgaclk_parent = "soc0_pll";
>  			break;
>  		default:
> -- 
> 2.21.0
>
Stephen Boyd Jan. 5, 2020, 7:27 a.m. UTC | #3
Quoting Linus Walleij (2019-12-17 13:05:04)
> Some of the special PRCMU firmware variants were not
> properly detected in the Ux500 clock driver, resulting
> in the wrong clock for the SGA.
> 
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
index 72ed97c6662a..0aedd42fad52 100644
--- a/drivers/clk/ux500/u8500_of_clk.c
+++ b/drivers/clk/ux500/u8500_of_clk.c
@@ -99,8 +99,10 @@  static void u8500_clk_init(struct device_node *np)
 	if (fw_version != NULL) {
 		switch (fw_version->project) {
 		case PRCMU_FW_PROJECT_U8500_C2:
+		case PRCMU_FW_PROJECT_U8500_MBL:
 		case PRCMU_FW_PROJECT_U8520:
 		case PRCMU_FW_PROJECT_U8420:
+		case PRCMU_FW_PROJECT_U8420_SYSCLK:
 			sgaclk_parent = "soc0_pll";
 			break;
 		default: