@@ -67,35 +67,47 @@ static const struct mtk_gate audio_clks[] = {
20),
};
+static_assert(ARRAY_SIZE(audio_clks) == CLK_AUDIO_NR_CLK);
+
+static const struct mtk_clk_desc audio_desc = {
+ .clks = audio_clks,
+ .num_clks = ARRAY_SIZE(audio_clks),
+};
+
static int clk_mt8183_audio_probe(struct platform_device *pdev)
{
- struct clk_hw_onecell_data *clk_data;
- int r;
- struct device_node *node = pdev->dev.of_node;
+ int ret;
- clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK);
+ ret = mtk_clk_simple_probe(pdev);
+ if (ret)
+ return ret;
- mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks),
- clk_data);
+ ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
+ if (ret)
+ goto err_remove_clks;
- r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
- if (r)
- return r;
+ return 0;
- r = devm_of_platform_populate(&pdev->dev);
- if (r)
- of_clk_del_provider(node);
+err_remove_clks:
+ mtk_clk_simple_remove(pdev);
+ return ret;
+}
+
+static int clk_mt8183_audio_remove(struct platform_device *pdev)
+{
+ of_platform_depopulate(&pdev->dev);
- return r;
+ return mtk_clk_simple_remove(pdev);
}
static const struct of_device_id of_match_clk_mt8183_audio[] = {
- { .compatible = "mediatek,mt8183-audiosys", },
+ { .compatible = "mediatek,mt8183-audiosys", .data = &audio_desc },
{}
};
static struct platform_driver clk_mt8183_audio_drv = {
.probe = clk_mt8183_audio_probe,
+ .remove = clk_mt8183_audio_remove,
.driver = {
.name = "clk-mt8183-audio",
.of_match_table = of_match_clk_mt8183_audio,
mtk_clk_simple_*() was added after the MT8183 clock drivers were merged. They provide shared boiler plate for clock providers that only have clock gates. Since the driver also populates child nodes, which are for the audio subsystem, it can't be completely converted to using the functions. Simplify the MT8183 audio clock driver using mtk_clk_simple_*(), sequencing the of_platform_{populate,unpopulate} calls manually and correctly. This also adds proper remove support for the driver. Since the mtk_clk_simple_probe() function allocates the clk_hw pointer array based on .num_clks given, it effectively requires there are no holes in the clock ID map. Check that the size of the array matches the number of clocks with a static assertion. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/clk/mediatek/clk-mt8183-audio.c | 40 ++++++++++++++++--------- 1 file changed, 26 insertions(+), 14 deletions(-)