| Message ID | 20230123201812.1230039-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/3] clk: qcom: cpu-8996: add missing cputype include | expand |
On 23.01.2023 21:18, Krzysztof Kozlowski wrote: > Include asm/cputype.h to fix ARMv7 compile test error: > > drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’: > drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/clk/qcom/clk-cpu-8996.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c > index ee76ef958d31..40c4dabc20a7 100644 > --- a/drivers/clk/qcom/clk-cpu-8996.c > +++ b/drivers/clk/qcom/clk-cpu-8996.c > @@ -49,6 +49,7 @@ > * detect voltage droops. > */ > > +#include <asm/cputype.h> > #include <linux/bitfield.h> > #include <linux/clk.h> > #include <linux/clk-provider.h>
Quoting Krzysztof Kozlowski (2023-01-23 12:18:10) > diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c > index ee76ef958d31..40c4dabc20a7 100644 > --- a/drivers/clk/qcom/clk-cpu-8996.c > +++ b/drivers/clk/qcom/clk-cpu-8996.c > @@ -49,6 +49,7 @@ > * detect voltage droops. > */ > > +#include <asm/cputype.h> Please include asm headers after linux headers > #include <linux/bitfield.h> > #include <linux/clk.h> > #include <linux/clk-provider.h>
On 25/01/2023 21:33, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2023-01-23 12:18:10) >> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c >> index ee76ef958d31..40c4dabc20a7 100644 >> --- a/drivers/clk/qcom/clk-cpu-8996.c >> +++ b/drivers/clk/qcom/clk-cpu-8996.c >> @@ -49,6 +49,7 @@ >> * detect voltage droops. >> */ >> >> +#include <asm/cputype.h> > > Please include asm headers after linux headers Ack Best regards, Krzysztof
On Mon, 23 Jan 2023 21:18:10 +0100, Krzysztof Kozlowski wrote: > Include asm/cputype.h to fix ARMv7 compile test error: > > drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’: > drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration] > > Applied, thanks! [1/3] clk: qcom: cpu-8996: add missing cputype include commit: 5930196eec0d5dc454db6418d82dcfb094c93373 [2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents (no commit info) [3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment (no commit info) Best regards,
diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c index ee76ef958d31..40c4dabc20a7 100644 --- a/drivers/clk/qcom/clk-cpu-8996.c +++ b/drivers/clk/qcom/clk-cpu-8996.c @@ -49,6 +49,7 @@ * detect voltage droops. */ +#include <asm/cputype.h> #include <linux/bitfield.h> #include <linux/clk.h> #include <linux/clk-provider.h>
Include asm/cputype.h to fix ARMv7 compile test error: drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’: drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/clk/qcom/clk-cpu-8996.c | 1 + 1 file changed, 1 insertion(+)