| Message ID | 20230226053953.4681-3-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | drivers: select REGMAP instead of depending on it | expand |
Quoting Randy Dunlap (2023-02-25 21:39:47) > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Riku Voipio <riku.voipio@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: linux-clk@vger.kernel.org > --- Applied to clk-fixes
diff -- a/drivers/clk/Kconfig b/drivers/clk/Kconfig --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -91,7 +91,7 @@ config COMMON_CLK_RK808 config COMMON_CLK_HI655X tristate "Clock driver for Hi655x" if EXPERT depends on (MFD_HI655X_PMIC || COMPILE_TEST) - depends on REGMAP + select REGMAP default MFD_HI655X_PMIC help This driver supports the hi655x PMIC clock. This
REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Riku Voipio <riku.voipio@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com> Cc: linux-clk@vger.kernel.org --- drivers/clk/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)