[v7,3/5] dt-bindings: clock: imx8mp: Add audiomix block control

Commit Message

Marek Vasut March 1, 2023, 4:32 p.m. UTC

Unlike the other block control IPs in i.MX8M, the audiomix is mostly a
series of clock gates and muxes. Add DT bindings for this IP.

Reviewed-by: Fabio Estevam <[e-mail]>
Reviewed-by: Marco Felsch <[e-mail]>
Reviewed-by: Peng Fan <[e-mail]>
Reviewed-by: Rob Herring <[e-mail]>
Tested-by: Adam Ford <[e-mail]> #imx8mp-beacon-kit
Tested-by: Alexander Stein <[e-mail]>
Signed-off-by: Marek Vasut <[e-mail]>
---
Cc: Abel Vesa <[e-mail]>
Cc: Alexander Stein <[e-mail]>
Cc: Fabio Estevam <[e-mail]>
Cc: Jacky Bai <[e-mail]>
Cc: Krzysztof Kozlowski <[e-mail]>
Cc: Laurent Pinchart <[e-mail]>
Cc: Luca Ceresoli <[e-mail]>
Cc: Lucas Stach <[e-mail]>
Cc: Marco Felsch <[e-mail]>
Cc: Michael Turquette <[e-mail]>
Cc: NXP Linux Team <[e-mail]>
Cc: Peng Fan <[e-mail]>
Cc: Pengutronix Kernel Team <[e-mail]>
Cc: Richard Cochran <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: Sascha Hauer <[e-mail]>
Cc: Shawn Guo <[e-mail]>
Cc: Stephen Boyd <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
V2: No change
V3: - Add missed RB from Rob from V1
    - Rename audio_ahb to plain ahb
V4: - Rebase on next 20230223
V5: Add TB from Adam and Alexander
V6: - Add RB from Fabio
    - Drop power-domain-names
    - Move reg below compatible property
V7: - Move #clock-cells below reg property
    - Sort required: list
    - Add RB from Marco, Peng and sort the tags
---
 .../bindings/clock/imx8mp-audiomix.yaml       | 79 +++++++++++++++++++
 1 file changed, 79 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml

Comments

Richard Leitner March 2, 2023, 11:51 a.m. UTC | #1

On Wed, Mar 01, 2023 at 05:32:55PM +0100, Marek Vasut wrote:
> Unlike the other block control IPs in i.MX8M, the audiomix is mostly a
> series of clock gates and muxes. Add DT bindings for this IP.
> 
> Reviewed-by: Fabio Estevam <[e-mail]>
> Reviewed-by: Marco Felsch <[e-mail]>
> Reviewed-by: Peng Fan <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> Tested-by: Adam Ford <[e-mail]> #imx8mp-beacon-kit
> Tested-by: Alexander Stein <[e-mail]>
> Signed-off-by: Marek Vasut <[e-mail]>

Hi Marek,
I've successfully tested this patch on a custom i.MX8MP board. Therefore
please feel free to add:

Tested-by: Richard Leitner <[e-mail]>

Krzysztof Kozlowski March 2, 2023, 1:01 p.m. UTC | #2

On 02/03/2023 12:51, Richard Leitner wrote:
> On Wed, Mar 01, 2023 at 05:32:55PM +0100, Marek Vasut wrote:
>> Unlike the other block control IPs in i.MX8M, the audiomix is mostly a
>> series of clock gates and muxes. Add DT bindings for this IP.
>>
>> Reviewed-by: Fabio Estevam <[e-mail]>
>> Reviewed-by: Marco Felsch <[e-mail]>
>> Reviewed-by: Peng Fan <[e-mail]>
>> Reviewed-by: Rob Herring <[e-mail]>
>> Tested-by: Adam Ford <[e-mail]> #imx8mp-beacon-kit
>> Tested-by: Alexander Stein <[e-mail]>
>> Signed-off-by: Marek Vasut <[e-mail]>
> 
> Hi Marek,
> I've successfully tested this patch on a custom i.MX8MP board. Therefore
> please feel free to add:

How can you test a binding patch on a board?

Best regards,
Krzysztof

Richard Leitner March 2, 2023, 3:07 p.m. UTC | #3

On Thu, Mar 02, 2023 at 02:01:02PM +0100, Krzysztof Kozlowski wrote:
> On 02/03/2023 12:51, Richard Leitner wrote:
> > On Wed, Mar 01, 2023 at 05:32:55PM +0100, Marek Vasut wrote:
> >> Unlike the other block control IPs in i.MX8M, the audiomix is mostly a
> >> series of clock gates and muxes. Add DT bindings for this IP.
> >>
> >> Reviewed-by: Fabio Estevam <[e-mail]>
> >> Reviewed-by: Marco Felsch <[e-mail]>
> >> Reviewed-by: Peng Fan <[e-mail]>
> >> Reviewed-by: Rob Herring <[e-mail]>
> >> Tested-by: Adam Ford <[e-mail]> #imx8mp-beacon-kit
> >> Tested-by: Alexander Stein <[e-mail]>
> >> Signed-off-by: Marek Vasut <[e-mail]>
> > 
> > Hi Marek,
> > I've successfully tested this patch on a custom i.MX8MP board. Therefore
> > please feel free to add:
> 
> How can you test a binding patch on a board?

I have no idea... Sorry. That text was copied/pasted. That shouldn't
have happened.

regards;rl

> 
> Best regards,
> Krzysztof
>

Patch

diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
new file mode 100644
index 0000000000000..ff9600474df20
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
@@ -0,0 +1,79 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/imx8mp-audiomix.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX8MP AudioMIX Block Control Binding
+
+maintainers:
+  - Marek Vasut <[e-mail]>
+
+description: |
+  NXP i.MX8M Plus AudioMIX is dedicated clock muxing and gating IP
+  used to control Audio related clock on the SoC.
+
+properties:
+  compatible:
+    const: fsl,imx8mp-audio-blk-ctrl
+
+  reg:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+  clocks:
+    minItems: 7
+    maxItems: 7
+
+  clock-names:
+    items:
+      - const: ahb
+      - const: sai1
+      - const: sai2
+      - const: sai3
+      - const: sai5
+      - const: sai6
+      - const: sai7
+
+  '#clock-cells':
+    const: 1
+    description:
+      The clock consumer should specify the desired clock by having the clock
+      ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8mp-clock.h
+      for the full list of i.MX8MP IMX8MP_CLK_AUDIOMIX_ clock IDs.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - power-domains
+  - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+  # Clock Control Module node:
+  - |
+    #include <dt-bindings/clock/imx8mp-clock.h>
+
+    clock-controller@30e20000 {
+        compatible = "fsl,imx8mp-audio-blk-ctrl";
+        reg = <0x30e20000 0x10000>;
+        #clock-cells = <1>;
+        clocks = <&clk IMX8MP_CLK_AUDIO_ROOT>,
+                 <&clk IMX8MP_CLK_SAI1>,
+                 <&clk IMX8MP_CLK_SAI2>,
+                 <&clk IMX8MP_CLK_SAI3>,
+                 <&clk IMX8MP_CLK_SAI5>,
+                 <&clk IMX8MP_CLK_SAI6>,
+                 <&clk IMX8MP_CLK_SAI7>;
+        clock-names = "ahb",
+                      "sai1", "sai2", "sai3",
+                      "sai5", "sai6", "sai7";
+        power-domains = <&pgc_audio>;
+    };
+
+...