| Message ID | 20230330084846.14516-1-shubhrajyoti.datta@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: clock: versal: Correct example dts | expand |
On 30/03/2023 10:48, Shubhrajyoti Datta wrote: > From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com> > > Correct firmware node name and compatible string in versal clock > dt-bindings. That was a valid compatible, so you need you describe why you are doing it. IOW, what was wrong and required correction. Because correcting a correct compatible is really not obvious. > > Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > --- > > Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml > index 229af98b1d30..4bbf96484b56 100644 > --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml > +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml > @@ -50,8 +50,8 @@ additionalProperties: false > examples: > - | > firmware { > - zynqmp_firmware: zynqmp-firmware { > - compatible = "xlnx,zynqmp-firmware"; > + versal_firmware: versal-firmware { No. If you touch it, at least make it really correct: Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml index 229af98b1d30..4bbf96484b56 100644 --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml @@ -50,8 +50,8 @@ additionalProperties: false examples: - | firmware { - zynqmp_firmware: zynqmp-firmware { - compatible = "xlnx,zynqmp-firmware"; + versal_firmware: versal-firmware { + compatible = "xlnx,versal-firmware"; method = "smc"; versal_clk: clock-controller { #clock-cells = <1>;