| Message ID | 20230408134820.76050-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | [1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock | expand |
On 8.04.2023 15:48, Krzysztof Kozlowski wrote: > Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: > sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to > the GCC clock controller, so update the bindings hoping this is really > needed. This fixes warnings like: The initial commit 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") already consumed it on the .c side, so the bindings were wrong.. > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") s/this/98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > index b752542ee20c..ead6665b9a45 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > @@ -23,11 +23,13 @@ properties: > clocks: > items: > - description: Board XO source > + - description: Board active XO source > - description: Sleep clock source > > clock-names: > items: > - const: bi_tcxo > + - const: bi_tcxo_ao > - const: sleep_clk > > required: > @@ -47,8 +49,9 @@ examples: > compatible = "qcom,gcc-sm8250"; > reg = <0x00100000 0x1f0000>; > clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>, > <&sleep_clk>; > - clock-names = "bi_tcxo", "sleep_clk"; > + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; > #clock-cells = <1>; > #reset-cells = <1>; > #power-domain-cells = <1>;
Quoting Krzysztof Kozlowski (2023-04-08 06:48:18) > Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: > sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to > the GCC clock controller, so update the bindings hoping this is really > needed. This fixes warnings like: > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Sat, 08 Apr 2023 15:48:18 +0200, Krzysztof Kozlowski wrote: > Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: > sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to > the GCC clock controller, so update the bindings hoping this is really > needed. This fixes warnings like: > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml index b752542ee20c..ead6665b9a45 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml @@ -23,11 +23,13 @@ properties: clocks: items: - description: Board XO source + - description: Board active XO source - description: Sleep clock source clock-names: items: - const: bi_tcxo + - const: bi_tcxo_ao - const: sleep_clk required: @@ -47,8 +49,9 @@ examples: compatible = "qcom,gcc-sm8250"; reg = <0x00100000 0x1f0000>; clocks = <&rpmhcc RPMH_CXO_CLK>, + <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>; - clock-names = "bi_tcxo", "sleep_clk"; + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>;
Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to the GCC clock controller, so update the bindings hoping this is really needed. This fixes warnings like: sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)