diff mbox series

[v2] dt-bindings: clock: versal: Add versal-net compatible string

Message ID 20230413101134.10627-1-shubhrajyoti.datta@amd.com (mailing list archive)
State Changes Requested, archived
Headers show
Series [v2] dt-bindings: clock: versal: Add versal-net compatible string | expand

Commit Message

Shubhrajyoti Datta April 13, 2023, 10:11 a.m. UTC 
From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>

Add dt-binding documentation for Versal NET platforms.

Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---

Changes in v2:
Move to enum
Drop driver patch

 Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski April 13, 2023, 2:27 p.m. UTC | #1 
On 13/04/2023 12:11, Shubhrajyoti Datta wrote:
> From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
> 
> Add dt-binding documentation for Versal NET platforms.
> 
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.

First version was sent correctly, so why you decided here to do it
differently?

Anyway, you did not implement comments we asked you. There is no way
this binding and your DTS works. There is no way you tested it.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
index 4bbf96484b56..0029d94c4e1e 100644
--- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
+++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
@@ -20,7 +20,9 @@  select: false
 
 properties:
   compatible:
-    const: xlnx,versal-clk
+    enum:
+      - xlnx,versal-clk
+      - xlnx,versal-net-clk
 
   "#clock-cells":
     const: 1