| Message ID | 20230507134148.16530-1-marek.vasut+renesas@mailbox.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data() | expand |
On Sun, 7 May 2023 15:41:47 +0200 Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Use device_get_match_data() which, unlike of_device_get_match_data(), > is compatible with other firmware interfaces than just OF. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > --- > Cc: Alex Helms <alexander.helms.jy@renesas.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Luca Ceresoli <luca.ceresoli@bootlin.com> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Nathan Chancellor <nathan@kernel.org> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Tom Rix <trix@redhat.com> > Cc: linux-clk@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Hi Marek, On Sun, May 7, 2023 at 3:42 PM Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Use device_get_match_data() which, unlike of_device_get_match_data(), > is compatible with other firmware interfaces than just OF. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Thanks for your patch! > --- a/drivers/clk/clk-versaclock5.c > +++ b/drivers/clk/clk-versaclock5.c > @@ -953,7 +953,7 @@ static int vc5_probe(struct i2c_client *client) > > i2c_set_clientdata(client, vc5); > vc5->client = client; > - vc5->chip_info = of_device_get_match_data(&client->dev); > + vc5->chip_info = device_get_match_data(&client->dev); > > vc5->pin_xin = devm_clk_get(&client->dev, "xin"); > if (PTR_ERR(vc5->pin_xin) == -EPROBE_DEFER) LGTM, but probably you want to include <linux/property.h> explicitly? Gr{oetje,eeting}s, Geert
diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c index 5452471b7ba5..7d91d5e862a3 100644 --- a/drivers/clk/clk-versaclock5.c +++ b/drivers/clk/clk-versaclock5.c @@ -953,7 +953,7 @@ static int vc5_probe(struct i2c_client *client) i2c_set_clientdata(client, vc5); vc5->client = client; - vc5->chip_info = of_device_get_match_data(&client->dev); + vc5->chip_info = device_get_match_data(&client->dev); vc5->pin_xin = devm_clk_get(&client->dev, "xin"); if (PTR_ERR(vc5->pin_xin) == -EPROBE_DEFER)
Use device_get_match_data() which, unlike of_device_get_match_data(), is compatible with other firmware interfaces than just OF. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: Alex Helms <alexander.helms.jy@renesas.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Tom Rix <trix@redhat.com> Cc: linux-clk@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org --- drivers/clk/clk-versaclock5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)