From patchwork Thu Jul 6 12:47:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13303671 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632DCEB64D9 for ; Thu, 6 Jul 2023 12:47:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbjGFMri (ORCPT ); Thu, 6 Jul 2023 08:47:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbjGFMrh (ORCPT ); Thu, 6 Jul 2023 08:47:37 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E0251FF1 for ; Thu, 6 Jul 2023 05:47:17 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-66872d4a141so528981b3a.1 for ; Thu, 06 Jul 2023 05:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688647636; x=1691239636; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oz3eFvCoH8VMOdDsuRaaEYtU3Bx4lHQ1ug4lyEzFPEw=; b=he4hjKQjYDtk50xePCiH1Ss+IYmU1WredzipkMpOaQuXWkuasuL5cU/UifneRnf62w yR+/ixt6R4ESh2taNjWKC2JYz6DtokxL4qXPHDYcAX17PP8Uq8rBc9V0mGT+oWX0Y5Ad HxZwTPL+OhyGDugSaHl9LDSiKAWTT/jCmw9HDwJ/uS01hFXqopOg+PSv8pGlzJd00SBG +TedV4g39Lnptc8H5kGcrCjsybdSf3El1oJCJHfEtJiH+awHxSe8fmw+F920lribxFYy /KmLdrV6Rez2dZNfb+uQz0UNWhXB7iYJM0PY4quVDjIBMOtvn0nRd8/jP5uZGHTdGtLk Tguw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688647636; x=1691239636; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oz3eFvCoH8VMOdDsuRaaEYtU3Bx4lHQ1ug4lyEzFPEw=; b=TGEmWKIFzMFQYL5OqyftR2O0UCqaT4oTo7DtXGeQynJHte/9Xya+YkD66Qx+hvmNi9 Z7m01V9M1wlhwtJCp3VuclKo4Z8Dds9iGGYZ5KdLf3vZQRL3QGKrBsCS9kLbUF8gyrKz UiYhZ7L1xI/dd0uAeYsLF1deII9Adj0uPSWcVPez1cTR9OHb3rDT5KhSToWyfH7kCeFN Q7xfW/XLtXZstp2y8gOY1tkTwblj3A6untlQ8Y/6YRKYE9ofr7q7GZw34LIYeXhx67xQ fNau+1KRF87gVlsFPVy9xODs78Kqbn1CF/jGP225M7u0vMHUhHkBz0Ptbn9sGdW+4VR3 PU4w== X-Gm-Message-State: ABy/qLaiyiaY1VVecXSSEhi/uiNQ8IQ6+9hJMB04AVGzg3sM7IWNJJGu GAEHpO4b+oqc/p+CwbJUhvTwXisx57QZtkLHtw== X-Google-Smtp-Source: APBJJlG7Z3x52Kkhx6a2YCvXWlkBD0byz59sKqA41aeJvXP2WI89Sh2NDFoHMcklC1pDEyShwf+bOg== X-Received: by 2002:a05:6a00:1912:b0:682:57f0:7c00 with SMTP id y18-20020a056a00191200b0068257f07c00mr1482885pfi.3.1688647635979; Thu, 06 Jul 2023 05:47:15 -0700 (PDT) Received: from localhost.localdomain ([117.216.120.100]) by smtp.gmail.com with ESMTPSA id t21-20020a62ea15000000b00666e649ca46sm1227066pfh.101.2023.07.06.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 05:47:15 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org Cc: konrad.dybcio@linaro.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH] Revert "clk: gcc-sc8280xp: keep PCIe power-domains always-on" Date: Thu, 6 Jul 2023 18:17:00 +0530 Message-Id: <20230706124700.12447-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org This reverts commit 12d2a4769380f0dc9ba6f827839869db2b81ef00. With the minimal system suspend support in place for the PCIe driver that keeps the interconnect path active, the ALWAYS_ON flags can now be dropped. Signed-off-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-sc8280xp.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c index 04a99dbaa57e..07eb6110442c 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -6774,10 +6774,6 @@ static struct gdsc pcie_1_tunnel_gdsc = { .flags = VOTABLE, }; -/* - * The Qualcomm PCIe driver does not yet implement suspend so to keep the - * PCIe power domains always-on for now. - */ static struct gdsc pcie_2a_gdsc = { .gdscr = 0x9d004, .collapse_ctrl = 0x52128, @@ -6786,7 +6782,7 @@ static struct gdsc pcie_2a_gdsc = { .name = "pcie_2a_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE, }; static struct gdsc pcie_2b_gdsc = { @@ -6797,7 +6793,7 @@ static struct gdsc pcie_2b_gdsc = { .name = "pcie_2b_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE, }; static struct gdsc pcie_3a_gdsc = { @@ -6808,7 +6804,7 @@ static struct gdsc pcie_3a_gdsc = { .name = "pcie_3a_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE, }; static struct gdsc pcie_3b_gdsc = { @@ -6819,7 +6815,7 @@ static struct gdsc pcie_3b_gdsc = { .name = "pcie_3b_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE, }; static struct gdsc pcie_4_gdsc = { @@ -6830,7 +6826,7 @@ static struct gdsc pcie_4_gdsc = { .name = "pcie_4_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE, }; static struct gdsc ufs_card_gdsc = {