From patchwork Thu Jul 6 14:08:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13303780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87833EB64DD for ; Thu, 6 Jul 2023 14:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232418AbjGFOI6 (ORCPT ); Thu, 6 Jul 2023 10:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232134AbjGFOI5 (ORCPT ); Thu, 6 Jul 2023 10:08:57 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 011A1173F for ; Thu, 6 Jul 2023 07:08:53 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-262ea2ff59dso434140a91.0 for ; Thu, 06 Jul 2023 07:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688652533; x=1691244533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bGfM/yd2eeNog37kmGdYUSawTbJfVWvJuEmuS/r9kdQ=; b=QyHYAWKjSRUqnEtohZsI6HWp+QFi4B36rz0mjzUObkR4jje3etuSC0hqmIiPoisKdU OrEEFqjbPx8Jb9o3eTqY4SJ1MNEzoyh7MamWkqiZLScosHfmmNh0fd0RgneSboh5ZLOU drWe4j+PM6/CV61jbApjN5rjVVmUZQzXMiD7T/+Twpa7BbgUE6YgSKRilEl7xzSzEJOP J8ww1NWqPyCBnTLZAn5VzcYSf3p/O2FogpLQDAmx7lKSXKywB+1D5UkJUWp0SQDUzh9A oLcbuQs3oUhHDf7gdcmT1HS3k+SHFGwAimK/FQ6hi0lddJBFhsX7iQvpD6mOAju6w2CA uMIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652533; x=1691244533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bGfM/yd2eeNog37kmGdYUSawTbJfVWvJuEmuS/r9kdQ=; b=AYWnk91pwOCK0vXRd4Oc2MeXzVaM6xmtMdwPt1tz1k6dCQLjYDh4D1NEXe17I8gQci PBYWemSP4vBvSbFAEEO9cMpIyHaboevHq3VFRmdE9kpxsi/zpJ/6+2cgUkLXWf7s1t4U Wnjf7ITSOmotdX6holIF0XfU/tHaP8IwUfPPFUazFlaZWY+/vh3sennTQiYvgFbQgmXc DRZKgdxOh8Rbzx+5s5/Lt5Bb5cg0IwVuhuPuZmwjOKNgqisLWxTr73GR0WJyHcFg+aYv +n9ll5youQDbCnxuhDjPqqye8W3FyA6JxBPH127KlH8ySAAJNadaYkpjZuLMroLy6Tuc 1gjA== X-Gm-Message-State: ABy/qLbf904SxXzzseaw7nNXWU562ZHNyC3R5KbeKBOi5rXf77BS8Ig6 PPSoWkIY1frX6m6hU0kUEf0W X-Google-Smtp-Source: APBJJlFOvKiFoT7+IHEw7FZVS7hfzVpYVJOmP7sE7vhUL+FPT9qqTjJ++W389w0FzoL0paB+3Q8H4A== X-Received: by 2002:a17:90a:6505:b0:262:e49b:12d0 with SMTP id i5-20020a17090a650500b00262e49b12d0mr1199514pjj.48.1688652533355; Thu, 06 Jul 2023 07:08:53 -0700 (PDT) Received: from localhost.localdomain ([117.216.120.100]) by smtp.gmail.com with ESMTPSA id s28-20020a63af5c000000b00528db73ed70sm1396609pgo.3.2023.07.06.07.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:08:52 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org Cc: konrad.dybcio@linaro.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v2] clk: qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state Date: Thu, 6 Jul 2023 19:38:42 +0530 Message-Id: <20230706140842.18059-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org With the minimal system suspend support in place for the PCIe driver that keeps the interconnect path voted, the ALWAYS_ON flag can now be dropped. Also, the PWRSTS_RET_ON flag should be used to allow the GDSCs to enter the retention state when the parent domain get's turned off during system suspend. Signed-off-by: Manivannan Sadhasivam --- Changes in v2: * Changed the patch from simple revert to changing the ALWAYS_ON flag to PWRSTS_RET_ON. drivers/clk/qcom/gcc-sc8280xp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c index 04a99dbaa57e..c59b0f91c87d 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -6786,7 +6786,7 @@ static struct gdsc pcie_2a_gdsc = { .name = "pcie_2a_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE | PWRSTS_RET_ON, }; static struct gdsc pcie_2b_gdsc = { @@ -6797,7 +6797,7 @@ static struct gdsc pcie_2b_gdsc = { .name = "pcie_2b_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE | PWRSTS_RET_ON, }; static struct gdsc pcie_3a_gdsc = { @@ -6808,7 +6808,7 @@ static struct gdsc pcie_3a_gdsc = { .name = "pcie_3a_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE | PWRSTS_RET_ON, }; static struct gdsc pcie_3b_gdsc = { @@ -6819,7 +6819,7 @@ static struct gdsc pcie_3b_gdsc = { .name = "pcie_3b_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE | PWRSTS_RET_ON, }; static struct gdsc pcie_4_gdsc = { @@ -6830,7 +6830,7 @@ static struct gdsc pcie_4_gdsc = { .name = "pcie_4_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE | ALWAYS_ON, + .flags = VOTABLE | PWRSTS_RET_ON, }; static struct gdsc ufs_card_gdsc = {