| Message ID | 20230929-clk-maple-versaclk-v1-1-24dd5b3d8689@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: versaclock: regmap modernisations | expand |
Quoting Mark Brown (2023-09-29 07:26:05) > The versaclock3 driver provides an _is_writeable() function which returns > true for all registers. This is the default assumption for regmaps so we > can remove the function for a very minor improvement in performance and > code size. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- Applied to clk-next
diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index 7ab2447bd203..a5ab48ff242c 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -586,17 +586,11 @@ static const struct clk_ops vc3_clk_mux_ops = { .get_parent = vc3_clk_mux_get_parent, }; -static bool vc3_regmap_is_writeable(struct device *dev, unsigned int reg) -{ - return true; -} - static const struct regmap_config vc3_regmap_config = { .reg_bits = 8, .val_bits = 8, .cache_type = REGCACHE_RBTREE, .max_register = 0x24, - .writeable_reg = vc3_regmap_is_writeable, }; static struct vc3_hw_data clk_div[5];
The versaclock3 driver provides an _is_writeable() function which returns true for all registers. This is the default assumption for regmaps so we can remove the function for a very minor improvement in performance and code size. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/clk/clk-versaclock3.c | 6 ------ 1 file changed, 6 deletions(-)