| Message ID | 20240217-clk-mv200-v2-5-b782e4eb66f7@outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | clk: hisilicon: add support for Hi3798MV200 | expand |
On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > This SoC is similar to Hi3798CV200. > > Also document the specific DLL regs and add an example for it. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > .../clock/hisilicon,clock-reset-generator.yaml | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml b/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml > index d37cd892473e..8ee844574eda 100644 > --- a/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml > +++ b/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml > @@ -44,12 +44,17 @@ properties: > - hisilicon,hi3519-crg > - hisilicon,hi3798cv200-crg > - hisilicon,hi3798cv200-sysctrl > + - hisilicon,hi3798mv200-crg > + - hisilicon,hi3798mv200-sysctrl > - const: syscon > - const: simple-mfd > > reg: > maxItems: 1 > > + ranges: > + maxItems: 1 > + > '#clock-cells': > const: 1 > > @@ -87,6 +92,12 @@ properties: > description: | > Reset controller for Hi3798CV200 GMAC module > > +patternProperties: > + '.*-dll@[0-9a-f]+': > + type: object > + description: | > + eMMC/SD delay-locked-loop (DLL) register subnode NAK, now all of the syscons have the DLL node? Best regards, Krzysztof
On 2/20/2024 6:15 PM, Krzysztof Kozlowski wrote: > On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> This SoC is similar to Hi3798CV200. >> >> Also document the specific DLL regs and add an example for it. >> >> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >> --- >> .../clock/hisilicon,clock-reset-generator.yaml | 36 ++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml b/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml >> index d37cd892473e..8ee844574eda 100644 >> --- a/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml >> +++ b/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml >> @@ -44,12 +44,17 @@ properties: >> - hisilicon,hi3519-crg >> - hisilicon,hi3798cv200-crg >> - hisilicon,hi3798cv200-sysctrl >> + - hisilicon,hi3798mv200-crg >> + - hisilicon,hi3798mv200-sysctrl >> - const: syscon >> - const: simple-mfd >> >> reg: >> maxItems: 1 >> >> + ranges: >> + maxItems: 1 >> + >> '#clock-cells': >> const: 1 >> >> @@ -87,6 +92,12 @@ properties: >> description: | >> Reset controller for Hi3798CV200 GMAC module >> >> +patternProperties: >> + '.*-dll@[0-9a-f]+': >> + type: object >> + description: | >> + eMMC/SD delay-locked-loop (DLL) register subnode > NAK, now all of the syscons have the DLL node? Oops. Forgot to remove this. it should be removed since it's now not used anymore. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml b/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml index d37cd892473e..8ee844574eda 100644 --- a/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml +++ b/Documentation/devicetree/bindings/clock/hisilicon,clock-reset-generator.yaml @@ -44,12 +44,17 @@ properties: - hisilicon,hi3519-crg - hisilicon,hi3798cv200-crg - hisilicon,hi3798cv200-sysctrl + - hisilicon,hi3798mv200-crg + - hisilicon,hi3798mv200-sysctrl - const: syscon - const: simple-mfd reg: maxItems: 1 + ranges: + maxItems: 1 + '#clock-cells': const: 1 @@ -87,6 +92,12 @@ properties: description: | Reset controller for Hi3798CV200 GMAC module +patternProperties: + '.*-dll@[0-9a-f]+': + type: object + description: | + eMMC/SD delay-locked-loop (DLL) register subnode + required: - compatible - '#clock-cells' @@ -137,3 +148,28 @@ examples: #clock-cells = <1>; }; }; + - | + crg: clock-reset-controller@8a22000 { + compatible = "hisilicon,hi3798mv200-crg", "syscon", "simple-mfd"; + reg = <0x8a22000 0x1000>; + ranges = <0x0 0x8a22000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + #clock-cells = <1>; + #reset-cells = <2>; + + emmc_sap_dll: sap-dll@39c { + compatible = "hisilicon,sdmmc-sap-dll", "syscon", "simple-mfd"; + reg = <0x39c 0x8>; + }; + + sdio0_sap_dll: sap-dll@3a4 { + compatible = "hisilicon,sdmmc-sap-dll", "syscon", "simple-mfd"; + reg = <0x3a4 0x8>; + }; + + sdio1_sap_dll: sap-dll@3ac { + compatible = "hisilicon,sdmmc-sap-dll", "syscon", "simple-mfd"; + reg = <0x3ac 0x8>; + }; + };