| Message ID | 20240308-mtk-fhctl-no-node-error-v1-1-51e446eb149a@collabora.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: mediatek: pllfh: Don't log error for missing fhctl node | expand |
Il 08/03/24 21:29, Nícolas F. R. A. Prado ha scritto: > Support for fhctl clocks in apmixedsys was introduced at a later point > and to this moment only one mt6795 based platform has a fhctl DT node > present. Therefore the fhctl support in apmixedsys should be seen as > optional and not cause an error when it is missing. > > Change the message's log level to warning. The warning level is chosen > so that it will still alert the fact that fhctl support might be > unintentionally missing, but without implying that this is necessarily > an issue. > > Even if the FHCTL DT nodes are added to all current platforms moving > forward, since those changes won't be backported, this ensures stable > kernel releases won't have live with this error. > > Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Quoting Nícolas F. R. A. Prado (2024-03-08 12:29:56) > Support for fhctl clocks in apmixedsys was introduced at a later point > and to this moment only one mt6795 based platform has a fhctl DT node > present. Therefore the fhctl support in apmixedsys should be seen as > optional and not cause an error when it is missing. > > Change the message's log level to warning. The warning level is chosen > so that it will still alert the fact that fhctl support might be > unintentionally missing, but without implying that this is necessarily > an issue. > > Even if the FHCTL DT nodes are added to all current platforms moving > forward, since those changes won't be backported, this ensures stable > kernel releases won't have live with this error. > > Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- Applied to clk-next
diff --git a/drivers/clk/mediatek/clk-pllfh.c b/drivers/clk/mediatek/clk-pllfh.c index 3a2b3f90be25..094ec8a26d66 100644 --- a/drivers/clk/mediatek/clk-pllfh.c +++ b/drivers/clk/mediatek/clk-pllfh.c @@ -68,7 +68,7 @@ void fhctl_parse_dt(const u8 *compatible_node, struct mtk_pllfh_data *pllfhs, node = of_find_compatible_node(NULL, NULL, compatible_node); if (!node) { - pr_err("cannot find \"%s\"\n", compatible_node); + pr_warn("cannot find \"%s\"\n", compatible_node); return; }
Support for fhctl clocks in apmixedsys was introduced at a later point and to this moment only one mt6795 based platform has a fhctl DT node present. Therefore the fhctl support in apmixedsys should be seen as optional and not cause an error when it is missing. Change the message's log level to warning. The warning level is chosen so that it will still alert the fact that fhctl support might be unintentionally missing, but without implying that this is necessarily an issue. Even if the FHCTL DT nodes are added to all current platforms moving forward, since those changes won't be backported, this ensures stable kernel releases won't have live with this error. Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- drivers/clk/mediatek/clk-pllfh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 11afac187274a6177a7ac82997f8691c0f469e41 change-id: 20240308-mtk-fhctl-no-node-error-d0f87b749d7c Best regards,