From patchwork Sat Apr 27 12:01:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13645661 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9723E433BF for ; Sat, 27 Apr 2024 12:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714219274; cv=none; b=ExtCswBnL1ZuXHk7YaNsebwYI/mOVpHomiAL0/k8DxgmzE4AUzG7SYEtBzC+HBLXJj4yvbBxuMge3uUU2Pz93d/GUqzjRqfnN3NsPoIszy8yvuXnFKl7JRd3O2MAsAb9ovySH3kCYYf1o0aeW2swiIqMToOhoRMQ2jQaoNMCvdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714219274; c=relaxed/simple; bh=GSvOEBFXHoGc6KMTfKG8BFzHpyuochW40eZKNzW32JE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=LqXcIbBYLB+vjEObr25SG8SP3atKJcsViVP7tUjHdA10dCujCsXLZVAJhlvc8oBEGq+N7ZiVcug0A4gYvzsCFGsSvJ2KpG9TY8jHxemTHz48w+OYcBaMTnySP+mJGCdX4rr4xaNR4Ezp6zrMqYRZS3hONynqX3jGbiATrRTPgM4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gJiA18u/; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gJiA18u/" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-56e477db7fbso4652273a12.3 for ; Sat, 27 Apr 2024 05:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714219271; x=1714824071; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=f9f/cpW0XeI0dWmGiPWyivG3BGF1w20mveSHrB3JwLk=; b=gJiA18u/+S+3vteegEH924GF6v7C3y3ktEkVYZ7ddDDUUcuufQcTGOXKGD0qLn+2z6 nU8j9EdfsTvNxkRpQSKEp39eXgei9LQyfQyZ6Gjml5waXcPF0rq4+lp8oTS7Pq9T0iD5 aCpIfgIOMgyNy41QYvo5dhU39CcSiXPEKK5j5GQ9LdzfDlsfWsGV+T5Yc9nsVcU+pP+J yyP2JgfUVPRrbGVdWg3zVbieNDsltWF7tugU2JINIIWpQmL9IiHgAUJDZkG3jEVbHy59 kYqmDSkZJWbUirbUNZgjJEiEaTARC8MjHd7bZ7yKSpWhEs6prbZZ3e6N0umtTVMN1Xwp ZvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714219271; x=1714824071; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f9f/cpW0XeI0dWmGiPWyivG3BGF1w20mveSHrB3JwLk=; b=pTtqPDasbofh6Rf2toQkF3shSLPaNNRKO7IDOyZqTqLxzuNL7wLmK2zUnoI+vjXbzH ZiUpfoKI6nAiYv86XP9ppvIY+GlCuw8L+KhiRpRdRiB8zBahOTHCPrWk+drTlQqwGQGh z4xQGxz93cLP7EPETJK6JT0NQF/CWwD+bopOFJhGgAmrnt9RVsDfWF9Z6xo9Pai/TZrE aLIe70jqv8bE9uCDYsGFljursVksQCSUfLB95uACoTmFjiD+KiYTCgDEz2zuVN5N399D 7AU0sRdyg5GRs7jJdJqij4aniWPKy4bkCkxnnURF6kynh7nU7Lh1Zihqci3Euo970tfp C5dw== X-Forwarded-Encrypted: i=1; AJvYcCUdbBix6fnQTRGvWhxISWhDz+/TqLi/7fT4IXcrzHJa67YnxvEAlKLVSKgXPeoy8fEAYZ20sXzRBL5nwCe8L5osu8HA8fKAOvYm X-Gm-Message-State: AOJu0Yw5VXfHsds0YJv7nqdRjCJ0OeiwS5B1kaUkEW0LQaLMMGqjOn1U ROcQWoG5yJmNeZtvsN+rZwrIrveBhgy//5+9P/pg7TyMxKETFjLY0b98zQ8zeEI= X-Google-Smtp-Source: AGHT+IEbkf/8tKlHPVtR4G9yGchH56fR4TRNu2Jsq2wFBeKbdiDerOlnuxdg+wrJj8zoaoeAhM7F+w== X-Received: by 2002:a05:6402:4344:b0:572:71b3:3c4d with SMTP id n4-20020a056402434400b0057271b33c4dmr531402edc.34.1714219270806; Sat, 27 Apr 2024 05:01:10 -0700 (PDT) Received: from [192.168.114.15] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id l6-20020aa7d946000000b005723151e99asm3845314eds.95.2024.04.27.05.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 05:01:10 -0700 (PDT) From: Konrad Dybcio Date: Sat, 27 Apr 2024 14:01:07 +0200 Subject: [PATCH] clk: qcom: gcc-sm8450: set OPS_PARENT_ENABLE on gcc_sdcc2_apps_clk_src Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240427-topic-8450sdc2-v1-1-631cbb59e0e5@linaro.org> X-B4-Tracking: v=1; b=H4sIAALpLGYC/x3MQQqAIBBA0avErBPUjKSrRAvTsWajohGBePek5 Vv8X6FgJiywDhUyPlQohg4xDmAvE05k5LpBcqm4kgu7YyLLtJp5cVayyVuPBwrUxkGPUkZP7z/ c9tY+2eDW3WAAAAA= To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Vinod Koul Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Konrad Dybcio X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714219268; l=1319; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=GSvOEBFXHoGc6KMTfKG8BFzHpyuochW40eZKNzW32JE=; b=q/ojXBP9DGmv83YzSffQUKiOa2EJtP8mw16lIw264BpFw8YFs6+27+zLYcY1F+HD5kXLfSW12 B/uCbTFr764C9gPhETN6FppKXvJ/2yt1q8USA3shSiiagw4Q+5GUkx0 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Similar to how it works on other SoCs, the top frequency of the SDHCI2 core clock is generated by a separate PLL (peculiar design choice) that is not guaranteed to be enabled (why does the clock framework not handle this by default?). Add the CLK_OPS_PARENT_ENABLE flag to make sure we're not muxing the RCG input to a dormant source. Fixes: db0c944ee92b ("clk: qcom: Add clock driver for SM8450") Reported-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8450.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: c0b832517f627ead3388c6f0c74e8ac10ad5774b change-id: 20240427-topic-8450sdc2-3fcfebe1e8ad Best regards, diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c index e86c58bc5e48..9a1d48ff22bc 100644 --- a/drivers/clk/qcom/gcc-sm8450.c +++ b/drivers/clk/qcom/gcc-sm8450.c @@ -935,7 +935,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_7, .num_parents = ARRAY_SIZE(gcc_parent_data_7), - .flags = CLK_SET_RATE_PARENT, + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, .ops = &clk_rcg2_floor_ops, }, };