| Message ID | 20240429214502.1363592-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | clk: imx: imx8mp: Switch to RUNTIME_PM_OPS() | expand |
> Subject: [PATCH] clk: imx: imx8mp: Switch to RUNTIME_PM_OPS() > > From: Fabio Estevam <festevam@denx.de> > > Replace SET_RUNTIME_PM_OPS() with its modern alternative > RUNTIME_PM_OPS(). > > The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the > compiler to evaluate if the suspend/resume() functions are used at buid time > or are simply dead code. > > This fixes the following s390 allmodconfig build errors: > > drivers/clk/imx/clk-imx8mp-audiomix.c:363:12: error: > 'clk_imx8mp_audiomix_runtime_resume' defined but not used [- > Werror=unused-function] > 363 | static int clk_imx8mp_audiomix_runtime_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error: > 'clk_imx8mp_audiomix_runtime_suspend' defined but not used [- > Werror=unused-function] > 356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Closes: > https://lore.ke/ > rnel.org%2Flinux- > clk%2FCA%2BG9fYuP7S%2Ba89Ep5g5_Ad69EMwRkJ8nM%2BMMTzbEcP%2B > 6H2oMXQ%40mail.gmail.com%2FT%2F%23u&data=05%7C02%7Cpeng.fan% > 40nxp.com%7C9d12d569610c457011aa08dc6895a8e2%7C686ea1d3bc2b4c > 6fa92cd99c5c301635%7C0%7C0%7C638500239186820103%7CUnknown%7 > CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > LCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=EcUHmggtxNEkO3DFCbInsDhnk > MErp58G6wG4PGJ0lws%3D&reserved=0 > Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for > power saving") > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/clk/imx/clk-imx8mp-audiomix.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk- > imx8mp-audiomix.c > index 574a032309c1..6a9b48b20cd6 100644 > --- a/drivers/clk/imx/clk-imx8mp-audiomix.c > +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c > @@ -368,8 +368,8 @@ static int > clk_imx8mp_audiomix_runtime_resume(struct device *dev) } > > static const struct dev_pm_ops clk_imx8mp_audiomix_pm_ops = { > - SET_RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend, > - clk_imx8mp_audiomix_runtime_resume, NULL) > + RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend, > + clk_imx8mp_audiomix_runtime_resume, NULL) > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > pm_runtime_force_resume) > }; > @@ -386,7 +386,7 @@ static struct platform_driver > clk_imx8mp_audiomix_driver = { > .driver = { > .name = "imx8mp-audio-blk-ctrl", > .of_match_table = clk_imx8mp_audiomix_of_match, > - .pm = &clk_imx8mp_audiomix_pm_ops, > + .pm = pm_ptr(&clk_imx8mp_audiomix_pm_ops), > }, > }; > > -- > 2.34.1 >
On Mon, 29 Apr 2024 18:45:02 -0300, Fabio Estevam wrote: > Replace SET_RUNTIME_PM_OPS() with its modern alternative RUNTIME_PM_OPS(). > > The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the > compiler to evaluate if the suspend/resume() functions are used at > buid time or are simply dead code. > > This fixes the following s390 allmodconfig build errors: > > [...] Applied, thanks! [1/1] clk: imx: imx8mp: Switch to RUNTIME_PM_OPS() commit: 57939f392371fc93c203b781807c951018c29606 Best regards,
On Tue, 30 Apr 2024 at 03:15, Fabio Estevam <festevam@gmail.com> wrote: > > From: Fabio Estevam <festevam@denx.de> > > Replace SET_RUNTIME_PM_OPS() with its modern alternative RUNTIME_PM_OPS(). > > The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the > compiler to evaluate if the suspend/resume() functions are used at > buid time or are simply dead code. > > This fixes the following s390 allmodconfig build errors: > > drivers/clk/imx/clk-imx8mp-audiomix.c:363:12: error: > 'clk_imx8mp_audiomix_runtime_resume' defined but not used > [-Werror=unused-function] > 363 | static int clk_imx8mp_audiomix_runtime_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error: > 'clk_imx8mp_audiomix_runtime_suspend' defined but not used > [-Werror=unused-function] > 356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Closes: https://lore.kernel.org/linux-clk/CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com/T/#u > Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for power saving") > Signed-off-by: Fabio Estevam <festevam@denx.de> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> Thanks for the fix patch. > --- > drivers/clk/imx/clk-imx8mp-audiomix.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c > index 574a032309c1..6a9b48b20cd6 100644 > --- a/drivers/clk/imx/clk-imx8mp-audiomix.c > +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c > @@ -368,8 +368,8 @@ static int clk_imx8mp_audiomix_runtime_resume(struct device *dev) > } > > static const struct dev_pm_ops clk_imx8mp_audiomix_pm_ops = { > - SET_RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend, > - clk_imx8mp_audiomix_runtime_resume, NULL) > + RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend, > + clk_imx8mp_audiomix_runtime_resume, NULL) > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > pm_runtime_force_resume) > }; > @@ -386,7 +386,7 @@ static struct platform_driver clk_imx8mp_audiomix_driver = { > .driver = { > .name = "imx8mp-audio-blk-ctrl", > .of_match_table = clk_imx8mp_audiomix_of_match, > - .pm = &clk_imx8mp_audiomix_pm_ops, > + .pm = pm_ptr(&clk_imx8mp_audiomix_pm_ops), > }, > }; > > -- > 2.34.1 -- Linaro LKFT https://lkft.linaro.org
diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c index 574a032309c1..6a9b48b20cd6 100644 --- a/drivers/clk/imx/clk-imx8mp-audiomix.c +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c @@ -368,8 +368,8 @@ static int clk_imx8mp_audiomix_runtime_resume(struct device *dev) } static const struct dev_pm_ops clk_imx8mp_audiomix_pm_ops = { - SET_RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend, - clk_imx8mp_audiomix_runtime_resume, NULL) + RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend, + clk_imx8mp_audiomix_runtime_resume, NULL) SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; @@ -386,7 +386,7 @@ static struct platform_driver clk_imx8mp_audiomix_driver = { .driver = { .name = "imx8mp-audio-blk-ctrl", .of_match_table = clk_imx8mp_audiomix_of_match, - .pm = &clk_imx8mp_audiomix_pm_ops, + .pm = pm_ptr(&clk_imx8mp_audiomix_pm_ops), }, };