| Message ID | 20240605172154.193047-2-knaerzche@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | Add SFC support for RK3128 | expand |
On Wed, Jun 05, 2024 at 07:21:52PM +0200, Alex Bee wrote: > Add a clock id for SFC's AHB clock. Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Wed, Jun 05, 2024 at 07:21:52PM +0200, Alex Bee wrote: > Add a clock id for SFC's AHB clock. > > Signed-off-by: Alex Bee <knaerzche@gmail.com> > --- > NB: I've added the new id at the top of existing HCLK's, since adding it at > the bottom would change CLK_NR_CLKS and therefore the ABI and there is > plenty of "free" ids between PCLK_MIPIPHY and HCLK_SPDIF. We've removed a bunch of things like "CLK_NR_CLKS" from bindings before and advocate against adding them. Patches like this being the reason why..
Am 05.06.24 um 19:58 schrieb Conor Dooley: > On Wed, Jun 05, 2024 at 07:21:52PM +0200, Alex Bee wrote: >> Add a clock id for SFC's AHB clock. >> >> Signed-off-by: Alex Bee <knaerzche@gmail.com> >> --- >> NB: I've added the new id at the top of existing HCLK's, since adding it at >> the bottom would change CLK_NR_CLKS and therefore the ABI and there is >> plenty of "free" ids between PCLK_MIPIPHY and HCLK_SPDIF. > We've removed a bunch of things like "CLK_NR_CLKS" from bindings before > and advocate against adding them. Patches like this being the reason > why.. Yeah, sure ... I thought removing it would be little out of scope for this series. But as we are already having a helper for finding the "max id" for Rockchip clocks, I'll resend and remove that annoying macro and add the new id at the bottom of the existing (where it belongs). Alex
diff --git a/include/dt-bindings/clock/rk3128-cru.h b/include/dt-bindings/clock/rk3128-cru.h index 1be455ba4985..a6bd7f13d7f8 100644 --- a/include/dt-bindings/clock/rk3128-cru.h +++ b/include/dt-bindings/clock/rk3128-cru.h @@ -119,6 +119,7 @@ #define PCLK_MIPIPHY 370 /* hclk gates */ +#define HCLK_SFC 439 #define HCLK_SPDIF 440 #define HCLK_GPS 441 #define HCLK_USBHOST 442
Add a clock id for SFC's AHB clock. Signed-off-by: Alex Bee <knaerzche@gmail.com> --- NB: I've added the new id at the top of existing HCLK's, since adding it at the bottom would change CLK_NR_CLKS and therefore the ABI and there is plenty of "free" ids between PCLK_MIPIPHY and HCLK_SPDIF. include/dt-bindings/clock/rk3128-cru.h | 1 + 1 file changed, 1 insertion(+)