| Message ID | 20240627205309.28742-2-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node | expand |
On Thu, 27 Jun 2024 22:52:57 +0200, Christian Marangi wrote: > Add required syscon compatible for mt7622 pciesys. This is required for > SATA interface as the regs are shared. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../bindings/clock/mediatek,mt7622-pciesys.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.example.dtb: clock-controller@1a100800: compatible: 'oneOf' conditional failed, one must be fixed: ['mediatek,mt7622-pciesys'] is too short 'mediatek,mt7629-pciesys' was expected from schema $id: http://devicetree.org/schemas/clock/mediatek,mt7622-pciesys.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240627205309.28742-2-ansuelsmth@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml index c77111d10f90..17f0d960c314 100644 --- a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml +++ b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml @@ -14,9 +14,11 @@ maintainers: properties: compatible: - enum: - - mediatek,mt7622-pciesys - - mediatek,mt7629-pciesys + oneOf: + - items: + - const: mediatek,mt7622-pciesys + - const: syscon + - const: mediatek,mt7629-pciesys reg: maxItems: 1
Add required syscon compatible for mt7622 pciesys. This is required for SATA interface as the regs are shared. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- .../bindings/clock/mediatek,mt7622-pciesys.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)