From patchwork Thu Oct 24 03:34:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhangzekun (A)" X-Patchwork-Id: 13848280 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD1D15B543 for ; Thu, 24 Oct 2024 03:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729741158; cv=none; b=JCQLdQgxqlWGJZTNAAupUcwx7ypXaBfPwV7/ppiMHe8uQ/h1FAQEq66ENSF+yJDvE+GMu7ODmCQoYZiXcjW9kygSStg5ms/Cflaf68V8wCr543qPEZLpY0iYAWIu3hb/ADFkHkWBoEos0R8YNsuyDhaeC+wKxahBrf2g5NTSNjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729741158; c=relaxed/simple; bh=VnAyf1t3SWlaAaDHBJmgxAmvm+OOiSLwPEYNcOySnT4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WDJ3BBuREmXx64agH9/1lah4GUj/8QCvmdQ1VAcyLBvfr1EFAX0moFRuikZrgjmBZtSlq6MvnsdGgAqNDgfVvBhrZdxTuTxUtGKa0rLYeF5N3/+8JyfXILJZesC+8JD3PxbSXwjB+/7NCZQ9Fq9TbtYE3gCcBnWD+N3/LgGIH6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4XYs790XckzyTkg; Thu, 24 Oct 2024 11:37:41 +0800 (CST) Received: from kwepemf500003.china.huawei.com (unknown [7.202.181.241]) by mail.maildlp.com (Postfix) with ESMTPS id 4D3671800A7; Thu, 24 Oct 2024 11:39:13 +0800 (CST) Received: from huawei.com (10.175.112.208) by kwepemf500003.china.huawei.com (7.202.181.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 24 Oct 2024 11:39:12 +0800 From: Zhang Zekun To: , , , , , , , , , , CC: , Subject: [RESEND PATCH 1/4] clk: imx: scu: Fix the return of uninitialized variable Date: Thu, 24 Oct 2024 11:34:21 +0800 Message-ID: <20241024033424.115417-2-zhangzekun11@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20241024033424.115417-1-zhangzekun11@huawei.com> References: <20241024033424.115417-1-zhangzekun11@huawei.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemf500003.china.huawei.com (7.202.181.241) The of_property_read_u32() can fail and leave the variable uninitialized, which will then be used. Return error if reading the property failed. Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") Signed-off-by: Zhang Zekun --- drivers/clk/imx/clk-scu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index b1dd0c08e091..95798c6fea1c 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -194,7 +194,7 @@ static bool imx_scu_clk_is_valid(u32 rsrc_id) int imx_clk_scu_init(struct device_node *np, const struct imx_clk_scu_rsrc_table *data) { - u32 clk_cells; + u32 clk_cells = 0; int ret, i; ret = imx_scu_get_handle(&ccm_ipc_handle);