| Message ID | 20241203134137.2114847-9-m.wilczynski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [RFC,v1,01/14] clk: thead: Refactor TH1520 clock driver to share common code | expand |
On Tue, 03 Dec 2024 14:41:31 +0100, Michal Wilczynski wrote: > Add power domain support to the Thead TH1520 clock controller bindings. > This enables devices to specify their power domain dependencies, > improving power management for components like the GPU. > > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> > --- > .../bindings/power/thead,th1520-power.yaml | 52 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/thead,th1520-power.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/thead,th1520-power.example.dtb: vosys@ffef528000: compatible: ['syscon'] is too short from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/thead,th1520-power.example.dtb: vosys@ffef528000: reg: [[255, 4015161344], [0, 4096]] is too long from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241203134137.2114847-9-m.wilczynski@samsung.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 03/12/2024 14:41, Michal Wilczynski wrote: > + > +title: T-HEAD TH1520 Power Domain Controller > + > +maintainers: > + - Michal Wilczynski <m.wilczynski@samsung.com> > + > +description: | > + The T-HEAD TH1520 SoC includes a power domain controller responsible for > + managing the power states of various hardware domains such as the GPU. > + > + This binding describes the power domain controller node, which can be used by Do not describe the binding. Describe the hardware. Entire paragraph feels pointless. > + devices to manage their power domains. > + > +properties: > + compatible: > + const: "thead,th1520-pd" You never tested the code you sent. Drop quotes. Limited review follows. > + > + thead,vosys-regmap: NAK. 'reg' is for this. > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + Phandle to a syscon node representing the shared register space of the VO (Video Output) subsystem. Please wrap code according to coding style (checkpatch is not a coding style description, but only a tool). > + This register space includes both clock control registers and other control registers used for > + operations like resetting the GPU. Since these registers reside in the same address space, > + access to them is coordinated through a shared syscon regmap provided by the specified syscon node. > + > + '#power-domain-cells': > + const: 1 > + > +required: > + - compatible > + - thead,vosys-regmap > + - '#power-domain-cells' > + > +additionalProperties: false > + > +examples: > + - | > + vosys_regmap: vosys@ffef528000 { > + compatible = "syscon"; > + reg = <0xff 0xef528000 0x0 0x1000>; > + }; Drop, not related. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/thead,th1520-power.yaml b/Documentation/devicetree/bindings/power/thead,th1520-power.yaml new file mode 100644 index 000000000000..528af54f4ca6 --- /dev/null +++ b/Documentation/devicetree/bindings/power/thead,th1520-power.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/thead,th1520-power.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: T-HEAD TH1520 Power Domain Controller + +maintainers: + - Michal Wilczynski <m.wilczynski@samsung.com> + +description: | + The T-HEAD TH1520 SoC includes a power domain controller responsible for + managing the power states of various hardware domains such as the GPU. + + This binding describes the power domain controller node, which can be used by + devices to manage their power domains. + +properties: + compatible: + const: "thead,th1520-pd" + + thead,vosys-regmap: + $ref: /schemas/types.yaml#/definitions/phandle + description: | + Phandle to a syscon node representing the shared register space of the VO (Video Output) subsystem. + This register space includes both clock control registers and other control registers used for + operations like resetting the GPU. Since these registers reside in the same address space, + access to them is coordinated through a shared syscon regmap provided by the specified syscon node. + + '#power-domain-cells': + const: 1 + +required: + - compatible + - thead,vosys-regmap + - '#power-domain-cells' + +additionalProperties: false + +examples: + - | + vosys_regmap: vosys@ffef528000 { + compatible = "syscon"; + reg = <0xff 0xef528000 0x0 0x1000>; + }; + + power-controller { + compatible = "thead,th1520-pd"; + thead,vosys-regmap = <&vosys_regmap>; + #power-domain-cells = <1>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 16fb58aa74b1..acbe311087ad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20187,6 +20187,7 @@ F: Documentation/devicetree/bindings/clock/thead,th1520-clk.yaml F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml F: Documentation/devicetree/bindings/pinctrl/thead,th1520-pinctrl.yaml +F: Documentation/devicetree/bindings/power/thead,th1520-power.yaml F: arch/riscv/boot/dts/thead/ F: drivers/clk/thead/ F: drivers/mailbox/mailbox-th1520.c
Add power domain support to the Thead TH1520 clock controller bindings. This enables devices to specify their power domain dependencies, improving power management for components like the GPU. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- .../bindings/power/thead,th1520-power.yaml | 52 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/thead,th1520-power.yaml