| Message ID | 20250224142831.485159-3-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | TQMa93xx on MBa93xxLA/CA LVDS support | expand |
On Mon, Feb 24, 2025 at 03:28:23PM +0100, Alexander Stein wrote: > Document the LDB bridge subnode and add the subnode into the example. > For the subnode to work, the block control must scan its subnodes and > bind drivers to them, do not misuse either simple-bus or simple-mfd > here. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > index b3554e7f9e76d..d914dea6ecbb5 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > @@ -24,6 +24,14 @@ properties: > reg: > maxItems: 1 > > + ranges: true > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > '#power-domain-cells': > const: 1 > > @@ -46,9 +54,20 @@ properties: > - const: csi > - const: dsi > > + bridge@20: > + type: object > + additionalProperties: true > + properties: > + compatible: > + contains: > + const: fsl,imx93-ldb > + > required: > - compatible > - reg > + - ranges > + - '#address-cells' > + - '#size-cells' > - power-domains > - clocks > - clock-names > @@ -77,4 +96,36 @@ examples: > clock-names = "apb", "axi", "nic", "disp", "cam", > "pxp", "lcdif", "isi", "csi", "dsi"; > #power-domain-cells = <1>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Given the address below is 0x20, this looks wrong unless the parent address is 0. > + > + bridge@20 { > + compatible = "fsl,imx93-ldb"; > + reg = <0x20 0x4>, <0x24 0x4>; > + reg-names = "ldb", "lvds"; > + clocks = <&clk IMX93_CLK_LVDS_GATE>; > + clock-names = "ldb"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + ldb_from_lcdif2: endpoint { > + remote-endpoint = <&lcdif2_to_ldb>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + ldb_lvds: endpoint { > + remote-endpoint = <&ldb_to_panel>; > + }; > + }; > + }; > + }; > }; > -- > 2.43.0 >
Am Dienstag, 25. Februar 2025, 15:52:54 CET schrieb Rob Herring: > ******************** > Achtung externe E-Mail: Öffnen Sie Anhänge und Links nur, wenn Sie wissen, dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten Sie die E-Mail im Zweifelsfall zur Prüfung an den IT-Helpdesk weiter. > Attention external email: Open attachments and links only if you know that they are from a secure source and are safe. In doubt forward the email to the IT-Helpdesk to check it. > ******************** > > On Mon, Feb 24, 2025 at 03:28:23PM +0100, Alexander Stein wrote: > > Document the LDB bridge subnode and add the subnode into the example. > > For the subnode to work, the block control must scan its subnodes and > > bind drivers to them, do not misuse either simple-bus or simple-mfd > > here. > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 51 +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > > index b3554e7f9e76d..d914dea6ecbb5 100644 > > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > > @@ -24,6 +24,14 @@ properties: > > reg: > > maxItems: 1 > > > > + ranges: true > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 1 > > + > > '#power-domain-cells': > > const: 1 > > > > @@ -46,9 +54,20 @@ properties: > > - const: csi > > - const: dsi > > > > + bridge@20: > > + type: object > > + additionalProperties: true > > + properties: > > + compatible: > > + contains: > > + const: fsl,imx93-ldb > > + > > required: > > - compatible > > - reg > > + - ranges > > + - '#address-cells' > > + - '#size-cells' > > - power-domains > > - clocks > > - clock-names > > @@ -77,4 +96,36 @@ examples: > > clock-names = "apb", "axi", "nic", "disp", "cam", > > "pxp", "lcdif", "isi", "csi", "dsi"; > > #power-domain-cells = <1>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > Given the address below is 0x20, this looks wrong unless the parent > address is 0. Thanks for pointing out. Because system-controller@4ac10000 is not a simple-bus I assume this needs explicit ranges, as you pointed out in your comment on Patch 4, no? Best regards, Alexander > > + > > + bridge@20 { > > + compatible = "fsl,imx93-ldb"; > > + reg = <0x20 0x4>, <0x24 0x4>; > > + reg-names = "ldb", "lvds"; > > + clocks = <&clk IMX93_CLK_LVDS_GATE>; > > + clock-names = "ldb"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + ldb_from_lcdif2: endpoint { > > + remote-endpoint = <&lcdif2_to_ldb>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + ldb_lvds: endpoint { > > + remote-endpoint = <&ldb_to_panel>; > > + }; > > + }; > > + }; > > + }; > > }; >
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml index b3554e7f9e76d..d914dea6ecbb5 100644 --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml @@ -24,6 +24,14 @@ properties: reg: maxItems: 1 + ranges: true + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + '#power-domain-cells': const: 1 @@ -46,9 +54,20 @@ properties: - const: csi - const: dsi + bridge@20: + type: object + additionalProperties: true + properties: + compatible: + contains: + const: fsl,imx93-ldb + required: - compatible - reg + - ranges + - '#address-cells' + - '#size-cells' - power-domains - clocks - clock-names @@ -77,4 +96,36 @@ examples: clock-names = "apb", "axi", "nic", "disp", "cam", "pxp", "lcdif", "isi", "csi", "dsi"; #power-domain-cells = <1>; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + bridge@20 { + compatible = "fsl,imx93-ldb"; + reg = <0x20 0x4>, <0x24 0x4>; + reg-names = "ldb", "lvds"; + clocks = <&clk IMX93_CLK_LVDS_GATE>; + clock-names = "ldb"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + ldb_from_lcdif2: endpoint { + remote-endpoint = <&lcdif2_to_ldb>; + }; + }; + + port@1 { + reg = <1>; + + ldb_lvds: endpoint { + remote-endpoint = <&ldb_to_panel>; + }; + }; + }; + }; };
Document the LDB bridge subnode and add the subnode into the example. For the subnode to work, the block control must scan its subnodes and bind drivers to them, do not misuse either simple-bus or simple-mfd here. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+)