| Message ID | 20250226235408.1339266-1-sboyd@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | clk: Print an error when clk registration fails | expand |
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index cf7720b9172f..466521248a34 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -4397,6 +4397,13 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) fail_name: kref_put(&core->ref, __clk_release); fail_out: + if (dev) { + dev_err_probe(dev, ret, "failed to register clk '%s' (%pS)\n", + init->name, hw); + } else { + pr_err("%pOF: error %pe: failed to register clk '%s' (%pS)\n", + np, ERR_PTR(ret), init->name, hw); + } return ERR_PTR(ret); }
We have a lot of driver code that prints an error message when registering a clk fails. Do that in the core function instead to consolidate code. This also helps drivers avoid the anti-pattern of accessing the struct clk_hw::init pointer after registration. Signed-off-by: Stephen Boyd <sboyd@kernel.org> --- drivers/clk/clk.c | 7 +++++++ 1 file changed, 7 insertions(+) base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b