| Message ID | 5d1ff6a7-7b3b-9bbf-f737-5347555a2076@free.fr (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | clk: qcom: msm8916: Add 2 clk options in defconfig | expand |
On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default > in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping > the 'default ARCH_QCOM' directive. > > Add the two options explicitly in the arm64 defconfig, to avoid > functional regressions. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> Acked-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > Bjorn, Andy, I believe you can take this patch through the qcom tree, > once Stephen takes the parent patch. > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 5a8e853833cf..3277944626c2 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -658,6 +658,8 @@ CONFIG_CLK_IMX8MQ=y > CONFIG_CLK_IMX8QXP=y > CONFIG_TI_SCI_CLK=y > CONFIG_COMMON_CLK_QCOM=y > +CONFIG_QCOM_A53PLL=y > +CONFIG_QCOM_CLK_APCS_MSM8916=y > CONFIG_QCOM_CLK_SMD_RPM=y > CONFIG_QCOM_CLK_RPMH=y > CONFIG_IPQ_GCC_8074=y > -- > 2.17.1
On 24/06/2019 15:57, Amit Kucheria wrote: > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: >> >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping >> the 'default ARCH_QCOM' directive. >> >> Add the two options explicitly in the arm64 defconfig, to avoid >> functional regressions. >> >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org> Stephen, Can you take the following two patches through the clk tree? [PATCH v2] clk: qcom: msm8916: Don't build by default [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig Regards.
Quoting Marc Gonzalez (2019-07-03 07:00:31) > On 24/06/2019 15:57, Amit Kucheria wrote: > > > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > >> > >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default > >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping > >> the 'default ARCH_QCOM' directive. > >> > >> Add the two options explicitly in the arm64 defconfig, to avoid > >> functional regressions. > >> > >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > > > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org> > > Stephen, > > Can you take the following two patches through the clk tree? > > [PATCH v2] clk: qcom: msm8916: Don't build by default > [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig > Did Andy pick up this defconfig change? The subject is misleading. defconfig changes should be something like arm64: defconfig: Add qcom clk options I don't think I need to pick up the defconfig change. It can go through Andy and arm-soc. So I'll just grab the first one and guess it won't break much on the way in.
On Wed, Aug 07, 2019 at 09:29:24PM -0700, Stephen Boyd wrote: > Quoting Marc Gonzalez (2019-07-03 07:00:31) > > On 24/06/2019 15:57, Amit Kucheria wrote: > > > > > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > >> > > >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default > > >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping > > >> the 'default ARCH_QCOM' directive. > > >> > > >> Add the two options explicitly in the arm64 defconfig, to avoid > > >> functional regressions. > > >> > > >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > > > > > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org> > > > > Stephen, > > > > Can you take the following two patches through the clk tree? > > > > [PATCH v2] clk: qcom: msm8916: Don't build by default > > [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig > > > > Did Andy pick up this defconfig change? The subject is misleading. > defconfig changes should be something like Neither Andy nor Bjorn has picked this. Could you please pick it up? (possibly with subject fixed up) > > arm64: defconfig: Add qcom clk options > > I don't think I need to pick up the defconfig change. It can go through > Andy and arm-soc. So I'll just grab the first one and guess it won't > break much on the way in. >
On Tue 27 Aug 07:48 PDT 2019, Niklas Cassel wrote: > On Wed, Aug 07, 2019 at 09:29:24PM -0700, Stephen Boyd wrote: > > Quoting Marc Gonzalez (2019-07-03 07:00:31) > > > On 24/06/2019 15:57, Amit Kucheria wrote: > > > > > > > On Mon, Jun 24, 2019 at 6:56 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > > >> > > > >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default > > > >> in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping > > > >> the 'default ARCH_QCOM' directive. > > > >> > > > >> Add the two options explicitly in the arm64 defconfig, to avoid > > > >> functional regressions. > > > >> > > > >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > > > > > > > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org> > > > > > > Stephen, > > > > > > Can you take the following two patches through the clk tree? > > > > > > [PATCH v2] clk: qcom: msm8916: Don't build by default > > > [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig > > > > > > > Did Andy pick up this defconfig change? The subject is misleading. > > defconfig changes should be something like > > Neither Andy nor Bjorn has picked this. > > Could you please pick it up? (possibly with subject fixed up) > Picked up and updated the subject. Thanks Marc! Regards, Bjorn > > > > arm64: defconfig: Add qcom clk options > > > > I don't think I need to pick up the defconfig change. It can go through > > Andy and arm-soc. So I'll just grab the first one and guess it won't > > break much on the way in. > >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5a8e853833cf..3277944626c2 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -658,6 +658,8 @@ CONFIG_CLK_IMX8MQ=y CONFIG_CLK_IMX8QXP=y CONFIG_TI_SCI_CLK=y CONFIG_COMMON_CLK_QCOM=y +CONFIG_QCOM_A53PLL=y +CONFIG_QCOM_CLK_APCS_MSM8916=y CONFIG_QCOM_CLK_SMD_RPM=y CONFIG_QCOM_CLK_RPMH=y CONFIG_IPQ_GCC_8074=y
QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 used to be enabled by default in drivers/clk/qcom/Kconfig. A recent patch changed that by dropping the 'default ARCH_QCOM' directive. Add the two options explicitly in the arm64 defconfig, to avoid functional regressions. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- Bjorn, Andy, I believe you can take this patch through the qcom tree, once Stephen takes the parent patch. --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+)