From patchwork Tue Aug 16 20:06:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9284495 X-Patchwork-Delegate: sboyd@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1E24560839 for ; Tue, 16 Aug 2016 20:06:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E5092875A for ; Tue, 16 Aug 2016 20:06:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 035AD2877D; Tue, 16 Aug 2016 20:06:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19E7828770 for ; Tue, 16 Aug 2016 20:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753675AbcHPUG0 (ORCPT ); Tue, 16 Aug 2016 16:06:26 -0400 Received: from mail-ua0-f181.google.com ([209.85.217.181]:33115 "EHLO mail-ua0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205AbcHPUGY (ORCPT ); Tue, 16 Aug 2016 16:06:24 -0400 Received: by mail-ua0-f181.google.com with SMTP id 74so140183311uau.0 for ; Tue, 16 Aug 2016 13:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8VjFXT+UPpzmoNMEhgB96ITkQgLxNo+QapzhvDkxiyc=; b=URH70J5kOFXrtFxp5hyrDr/GDVZU9NZXIFlEAVi6+ioV8PLXQx4Z/+ZdveOIQvB5iq noaoryi6EHuMFF9jFJuxN6nq8Cz0ZuF/GUh7Y4d2qat54lrdYLY1KsUo8eudKzjllKVu 07zJk7wFkyfXORfYLq5r4Dp5G8HZjRXJfP8XY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8VjFXT+UPpzmoNMEhgB96ITkQgLxNo+QapzhvDkxiyc=; b=Ph6niJuag7viT43PlQRY4J4sGfhnzSuBbY14SuAD1cH4b+xwOxlSR7ZtqR4Ha2SoTC v33RTTebpR57ML/OwHT+ysWtd5cL51QetJUOj6rT7B/SM1NWCzY/9OAml2bJVkRjGFOn sn5Fc7ZmA7lKku67Kqvrc78klOjbCuQUoMCnFxLobM7Ugmb0X8qXHaBj0MAkCW1WGTcC Z6/wCilCLiN2D8iarU11oryra7k2bRvqxzBcb5kpsd6Ix58eBGyRFswe7VrO2RvxDcIh +SJknom15n/1JFhf+DJmo5X/2xA9ICVgDRWNaMnwFufSsmsc4vjI1AKzYtHUP+D0jzO1 uUvA== X-Gm-Message-State: AEkoouuxzahPG2bZ9peY5eY5RMCftbn23u66uFMf/cUF0raCjdBTSyHZki5jpFDFYfwjDWnus11bDu54TMUKpSuR X-Received: by 10.176.3.22 with SMTP id 22mr14350186uat.89.1471377983714; Tue, 16 Aug 2016 13:06:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.37.65 with HTTP; Tue, 16 Aug 2016 13:06:03 -0700 (PDT) In-Reply-To: <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> References: <20160601231533.9354-1-stephen.boyd@linaro.org> <20160601231533.9354-18-stephen.boyd@linaro.org> <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> From: Stephen Boyd Date: Tue, 16 Aug 2016 13:06:03 -0700 Message-ID: Subject: Re: [PATCH 17/34] clk: maxgen: Migrate to clk_hw based OF and registration APIs To: Javier Martinez Canillas Cc: Javier Martinez Canillas , Michael Turquette , Stephen Boyd , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , linux-clk@vger.kernel.org Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jun 7, 2016 at 11:55 AM, Javier Martinez Canillas wrote: > On 06/07/2016 02:50 PM, Javier Martinez Canillas wrote: >> Hello Stephen, >> >> On Wed, Jun 1, 2016 at 7:15 PM, Stephen Boyd wrote: >>> Now that we have clk_hw based provider APIs to register clks, we >>> can get rid of struct clk pointers while registering clks in >>> these drivers, allowing us to move closer to a clear split of >>> consumer and provider clk APIs. >>> >>> Cc: Javier Martinez Canillas >> >> This email address doesn't exist anymore, you can use >> javier@osg.samsung.com instead. >> >>> Signed-off-by: Stephen Boyd >>> --- >>> >>> See commit 58657d189a2f and it's children for details on this >>> new registration API. >>> >> >> I tried this patch on top of linux-next and my Peach Pi Chromebook >> (that has a max77802 chip) failed to boot. Following is the relevant >> parts from the boot log: >> > > It seems the mailer did a mess with the line wrapping so here's another attempt: > Thanks! Found the problem too. ----8<----- return ret; --- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c index 4bb53fcf8639..5e8bac190698 100644 --- a/drivers/clk/clk-max-gen.c +++ b/drivers/clk/clk-max-gen.c @@ -169,7 +169,7 @@ int max_gen_clk_probe(struct platform_device *pdev, struct regmap *regmap, if (dev->of_node) { ret = of_clk_add_hw_provider(dev->of_node, of_clk_max_gen_get, - max_gen_clks); + max_gen_data); if (ret) { dev_err(dev, "failed to register OF clock provider\n");