From patchwork Tue Jun 6 10:04:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9768439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A8F4C60364 for ; Tue, 6 Jun 2017 10:05:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FC3626CFC for ; Tue, 6 Jun 2017 10:05:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80F6528417; Tue, 6 Jun 2017 10:05:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F1A126CFC for ; Tue, 6 Jun 2017 10:05:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751329AbdFFKEv (ORCPT ); Tue, 6 Jun 2017 06:04:51 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:36492 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdFFKEt (ORCPT ); Tue, 6 Jun 2017 06:04:49 -0400 Received: by mail-ot0-f195.google.com with SMTP id i31so1688836ota.3; Tue, 06 Jun 2017 03:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=SPkiXSsYv1GhqX/+sxpvEktqmaSU/rPBfX59Yptg6Hc=; b=ivStLXm3tgjSKCMag/ojReiCQ1W1321WRxhsis3j1pBg+q+UB08po+lriDOnfBdnt+ mfpr76SyG78iLCcuJ8P5Nn2smxM1JUv9ofAOiDhIBPz7119p+OPjyhFQsV5Eic06XzC/ OXZqL4mHItZQkvGEL2FeZ+mhS0FJGneZtOEJHZdQUBSnQQd7gaurW9bg5/bD2GrqEWKY 6rkWqVPrWL4xWUOpFEvqJ4U1NsU02VQOGXqHPUsSS6WOB4bszuNj31WQuYSAUqw7DP2u AOdiqp6amyvR0soQyFem/5CZpPwrksXQvZ00paoP69fyAt9UGyj6ayGzPbq/coXEFPkF +/eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=SPkiXSsYv1GhqX/+sxpvEktqmaSU/rPBfX59Yptg6Hc=; b=LuOYFub8YWkUq5zK5wTK4r+7ElB4JxfBrSMk0LBEnd2k+NwfzOwh3J9nUhLa+aSZ8p sZT0D8Z9OyRgvZdUU7Gh2YwnyNrKr5L/Wn2UwyjuClh4f8hlKeGnZglBErAun67YIiQF xuyt7XvR4921+HzJKZZNGg9EE+NpZF3P08djkQOe4EvBz8/nfJzyvLg0oY4xbHX84B/M vASWt55lntBkmywBmpTqtPXYPsVTPRKvNN5O7AIm1vSnuBAbx8547/oyALclf5vHOhbH Uc5PPy+A2W11GkBTHHjSxKKU1A42AQ4NTgADFv32fwkFvc4huUuAGyXbsjiIxmKznVSD dWrw== X-Gm-Message-State: AODbwcB5j5Od5n5miPaw/e9/BFJl7fugQUEc/1Od390Qb4dfUxHYOFas 6X4picq01ilK1+vNl5vNoUZp5WdRVA== X-Received: by 10.157.17.219 with SMTP id y27mr14837036oty.137.1496743488352; Tue, 06 Jun 2017 03:04:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.51.139 with HTTP; Tue, 6 Jun 2017 03:04:47 -0700 (PDT) In-Reply-To: <20170605144546.b6oh5sygrza22hbe@flea.lan> References: <20170602223006.1653-1-sboyd@codeaurora.org> <201706031243.qNvuUbQX%fengguang.wu@intel.com> <20170605144546.b6oh5sygrza22hbe@flea.lan> From: Arnd Bergmann Date: Tue, 6 Jun 2017 12:04:47 +0200 X-Google-Sender-Auth: y6j0I0pzMiqVv_LiZ7Sdxg_gMOE Message-ID: Subject: Re: [PATCH] clk: sunxi-ng: Move all clock types to a library To: Maxime Ripard Cc: kbuild test robot , Stephen Boyd , kbuild-all@01.org, Chen-Yu Tsai , Linux Kernel Mailing List , linux-clk@vger.kernel.org, Michael Turquette , Linux ARM Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jun 5, 2017 at 4:45 PM, Maxime Ripard wrote: > Hi, > > On Sat, Jun 03, 2017 at 12:22:32PM +0800, kbuild test robot wrote: >> Hi Stephen, >> >> [auto build test ERROR on sunxi/sunxi/for-next] >> [also build test ERROR on next-20170602] >> [cannot apply to clk/clk-next v4.12-rc3] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> sunxi_sid.c:(.data+0x1da8c): undefined reference to `ccu_gate_ops' >> sunxi_sid.c:(.data+0x1dac8): undefined reference to `ccu_gate_ops' >> sunxi_sid.c:(.data+0x1db20): undefined reference to `ccu_mux_ops' >> sunxi_sid.c:(.data+0x1db74): undefined reference to `ccu_mux_ops' >> sunxi_sid.c:(.data+0x1dbec): undefined reference to `ccu_mp_ops' >> sunxi_sid.c:(.data+0x1dc64): undefined reference to `ccu_mp_ops' > > It seems like even though the lib.a file is compiled properly, it is > never linked in. It looks like we would be supposed to add > drivers/clk/sunxi-ng/ to libs-y, but that doesn't seem to work for > Makefiles in drivers/* Ah, too bad. I see that only one directory under drivers/ uses something with lib.a, in drivers/firmware/efi/libstub/Makefile, but that seems to rely on being special-cased as well. However, this patch seems to fix it: It's not documented behavior, but I think it's still good enough, and improves the current version, unless there is another bug after we add this to your patch. Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/clk/sunxi-ng/Makefile b/drivers/clk/sunxi-ng/Makefile index cbc8cb4f70e3..321d3da7cc6a 100644 --- a/drivers/clk/sunxi-ng/Makefile +++ b/drivers/clk/sunxi-ng/Makefile @@ -18,16 +18,16 @@ lib-$(CONFIG_SUNXI_CCU) += ccu_nm.o lib-$(CONFIG_SUNXI_CCU) += ccu_mp.o # SoC support -obj-$(CONFIG_SUN50I_A64_CCU) += ccu-sun50i-a64.o -obj-$(CONFIG_SUN5I_CCU) += ccu-sun5i.o -obj-$(CONFIG_SUN6I_A31_CCU) += ccu-sun6i-a31.o -obj-$(CONFIG_SUN8I_A23_CCU) += ccu-sun8i-a23.o -obj-$(CONFIG_SUN8I_A33_CCU) += ccu-sun8i-a33.o -obj-$(CONFIG_SUN8I_A83T_CCU) += ccu-sun8i-a83t.o -obj-$(CONFIG_SUN8I_H3_CCU) += ccu-sun8i-h3.o -obj-$(CONFIG_SUN8I_V3S_CCU) += ccu-sun8i-v3s.o -obj-$(CONFIG_SUN8I_DE2_CCU) += ccu-sun8i-de2.o -obj-$(CONFIG_SUN8I_R_CCU) += ccu-sun8i-r.o -obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80.o -obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-de.o -obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-usb.o +obj-$(CONFIG_SUN50I_A64_CCU) += ccu-sun50i-a64.o lib.a +obj-$(CONFIG_SUN5I_CCU) += ccu-sun5i.o lib.a +obj-$(CONFIG_SUN6I_A31_CCU) += ccu-sun6i-a31.o lib.a +obj-$(CONFIG_SUN8I_A23_CCU) += ccu-sun8i-a23.o lib.a +obj-$(CONFIG_SUN8I_A33_CCU) += ccu-sun8i-a33.o lib.a +obj-$(CONFIG_SUN8I_A83T_CCU) += ccu-sun8i-a83t.o lib.a +obj-$(CONFIG_SUN8I_H3_CCU) += ccu-sun8i-h3.o lib.a +obj-$(CONFIG_SUN8I_V3S_CCU) += ccu-sun8i-v3s.o lib.a +obj-$(CONFIG_SUN8I_DE2_CCU) += ccu-sun8i-de2.o lib.a +obj-$(CONFIG_SUN8I_R_CCU) += ccu-sun8i-r.o lib.a +obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80.o lib.a +obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-de.o lib.a +obj-$(CONFIG_SUN9I_A80_CCU) += ccu-sun9i-a80-usb.o lib.a