From patchwork Tue Feb 6 15:44:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 10203209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C7546020F for ; Tue, 6 Feb 2018 15:44:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DF9C28AA5 for ; Tue, 6 Feb 2018 15:44:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 41CA028C6F; Tue, 6 Feb 2018 15:44:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B15E128AA5 for ; Tue, 6 Feb 2018 15:44:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbeBFPob (ORCPT ); Tue, 6 Feb 2018 10:44:31 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:42332 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbeBFPo3 (ORCPT ); Tue, 6 Feb 2018 10:44:29 -0500 Received: by mail-qk0-f193.google.com with SMTP id f68so2797708qke.9; Tue, 06 Feb 2018 07:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=hbcXbxgn3RPM1S5KoWzujxyBRYyhDViW7mA7LSO0sf4=; b=UZKqjwF5EpJVJhoEJ399LEZ679Y6FbW6rjezY6xiv+Ro9dy8EFEk8M81OvhPu27vCF 6/jjsA9yF1r88ktzXhRn6CODXoVuYZx+NYEtJ5ArJVB3vwGJzdm4dSGS6Z2K0opNgfCh OyfFJFcFxaekhWi7djR/+3XWffNeMZma6+v9GMa3kAxYb0tHaBLiXzxsuPgmSEU42Vpu k2c6cCTn7HDaqahlBW1dnKk+Ud/FfVIlbZQJAjyAfgggrg+oGAhLhUHEvA3xBdl/kp7p yM9h4uAOrkCFNwk6npLLWdsYJK4/FUWdGxgjYsvmJIQFpcEyD0EbievuMdIm7jZC8xHL V84w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=hbcXbxgn3RPM1S5KoWzujxyBRYyhDViW7mA7LSO0sf4=; b=rtda2nwRoW6NkizZj0l2m5TTTsAmaaPmUVql+3GJAClG/q/ysUP/kq1oDvVATKBBLL erBBgDqukBn7BKv0FxINaZbrQnK/XStMrYmPcZRUIVgnV/1G1PJinFkCkX9eiww182lt DZKMwIAQ6uiUSBAGlh8hfzNQOpJibu2r/mab3VIPl35Qb69JthJQKnc+a5SH+MalfFZB e19kiQX5ETw1KfkGU2JjEmra2mHDlYa54gdXe8zKbbEUOQTqCICbRHqW1+mJnDHiS1cO ZgElt8LyIOJ3bD+NtEB0z/QDIdK/ZAwlYy1/dYDBlg2h5xkU7MXcuPRYFJ6DGgZbdj18 Hr1w== X-Gm-Message-State: APf1xPABfuNQhVyaZSwgwz5SRjji42MmIBCC54ksZJ0MDBzm3vFy086E 5p6lEqH4fIUsmx8UFbY1JKNqYJOz+iQCJjc6dZkNCpnl X-Google-Smtp-Source: AH8x226hqokZNDK4t08oL6Zd8EEbSqIRP4YauaA8Qi/ritF/WJBpF7c7PgtxH0NKN5sJzKo4VY+Q1K99vCwk3KO+0Zo= X-Received: by 10.55.80.69 with SMTP id e66mr4073947qkb.45.1517931868699; Tue, 06 Feb 2018 07:44:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.39.197 with HTTP; Tue, 6 Feb 2018 07:44:28 -0800 (PST) In-Reply-To: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> References: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> From: Geert Uytterhoeven Date: Tue, 6 Feb 2018 16:44:28 +0100 X-Google-Sender-Auth: 50rDkzfYyd1uMjz_TtKXTSgbEEs Message-ID: Subject: Re: [RFC v4 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1 To: Fabrizio Castro Cc: Philipp Zabel , Rob Herring , Mark Rutland , Wim Van Sebroeck , Russell King , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Simon Horman , Magnus Damm , Geert Uytterhoeven , Wolfram Sang , Guenter Roeck , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Watchdog Mailing List , Linux-Renesas , linux-arm-kernel@lists.infradead.org, linux-clk , Chris Paterson , Biju Das , Ramesh Shanmugasundaram Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Fabrizio, On Wed, Jan 31, 2018 at 7:24 PM, Fabrizio Castro wrote: > the forth version of this series aims at consolidating the watchdog fix. > There is a discussion still in progress about the changes to the > watchdog driver, please see the following for more information: > https://patchwork.kernel.org/patch/10192435/ > > It doesn't look like leaving the restart handler in for Gen3 is going > to do any harm (but it may be unwelcome), perhaps esplicitly setting > its priority to a medium level (128) will help its adoption on Gen3 > as well? This is what this particular version is proposing. > > Also, although the latest implmentation of the reset vector hasn't > raised any problem so far, it hasn't received any feedback either. > Please do look into it to espose problems and weaknesses (if any). > > Finally, it would be great if someone could test this patch set on his > Gen2/Gen3/RZ/G1 board, and it would be awesome if that board was a > Lager with all of the cores enabled and working at the same time ;-) I applied your series, made the following change: and tried it on koelsch. Unfortunately it hangs: # cat > /dev/watchdog [wait 5s] [hang] However, it does work when booted with maxcpus=1, or when built with CONFIG_SMP=n. It also works when offlining CPU1 first: # echo 0 > /sys/devices/system/cpu/cpu1/online #cat > /dev/watchdog [wait 5s] [reboot] It does not work when offlining CPU0 first. This is on r8a7791 ES1.0. Gr{oetje,eeting}s, Geert --- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -499,6 +499,11 @@ status = "okay"; }; +&rwdt { + timeout-sec = <5>; + status = "okay"; +}; + &sata0 { status = "okay"; };