From patchwork Wed Apr 5 02:15:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9662885 X-Patchwork-Delegate: sboyd@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CAFEC60353 for ; Wed, 5 Apr 2017 02:15:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA89F28395 for ; Wed, 5 Apr 2017 02:15:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF493283E8; Wed, 5 Apr 2017 02:15:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A61928395 for ; Wed, 5 Apr 2017 02:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbdDECP1 (ORCPT ); Tue, 4 Apr 2017 22:15:27 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34363 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbdDECPZ (ORCPT ); Tue, 4 Apr 2017 22:15:25 -0400 Received: by mail-oi0-f67.google.com with SMTP id s11so10686oie.1; Tue, 04 Apr 2017 19:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8feFXddVFGzNa0sfWniSJmw+ffmGBUWFt/VWymlQ/Q4=; b=FrQVgwxcq4vIXKD9q7VCU9L/98mBlHDFu44Rffob6Ie9ffAIgxI5pDqaF5iyZVpfYa D4gDlx6s/rRWT+AG/xlkdcJ0B4I6Uyor3j/tUJ/UVMykc5zLQw0SminYf5BL+EyTMoRn 0dXDddNtEF9k3qiojRm2IUTvDpebd04rWWwcG4ZloSOPd2k+p3NxbI3DsSL9i9b/851U cDT+8ra7qb+w1u1ynDueAmsIzMor7+3hQ3rzMCTyPbOuWeOx+mA0CzaudIieguTSMMDZ O05wvN7tZSSh8Nj5B2wHTspbdQS8kbfeYVe2zGsKkkur0lCLFA/NkeIEIRncyFEyWavG exlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8feFXddVFGzNa0sfWniSJmw+ffmGBUWFt/VWymlQ/Q4=; b=UvH3SYg5WMXX54Ffklc6HvziPTCET+g1dULI/onGQelkJyaOocjgaLpbJBbkkSwj+x MRba0+zoTas1QYrFw8qUkv6pMQmc+mnJPUV/lTYK7GBUbcpQYVzGsYT3yNxCNpsUFfU6 YU7fsAKQTivbQ8VeZNW+LbqPHmS10YatQS+w4eBVL/9SKtHhz+fYxFS67pY3cToVlNl6 ajfRy5PuOJpDGyaVh2PX1miyZ5tSA+rdcIXYJT5qZNV2DfDyyoLgikfUlondUG3exWq4 5lFqOrVEET4ooG7j4AMs7OjhHY8C1ulsiXF4EkBMR/fytowd/9Ffz/SsVUVphPEiohrK XSiQ== X-Gm-Message-State: AFeK/H1VHvS76wA0I+wCPpNzvjcKehsAnn3xp28DJWEod02yg7ApeXVg1/tL96AvAXMdvgT1Bim2Z8zHTdyk9A== X-Received: by 10.157.80.140 with SMTP id b12mr13621730oth.81.1491358525079; Tue, 04 Apr 2017 19:15:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.43.210 with HTTP; Tue, 4 Apr 2017 19:15:24 -0700 (PDT) In-Reply-To: References: <20170330005029.6472-1-stefan@agner.ch> <20170330005029.6472-2-stefan@agner.ch> <20170401030312.GB24882@b29396-OptiPlex-7040> <5c8339900fa1bd6215fb94d4386f7e06@agner.ch> From: Fabio Estevam Date: Tue, 4 Apr 2017 23:15:24 -0300 Message-ID: Subject: Re: [PATCH 2/2] ARM: dts: imx7: add USDHC NAND clock to SDHC instances To: Stefan Agner Cc: Dong Aisheng , Shawn Guo , Sascha Hauer , Stephen Boyd , Dong Aisheng , Fabio Estevam , "robh+dt@kernel.org" , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-clk@vger.kernel.org, linux-kernel Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Apr 2, 2017 at 2:02 PM, Fabio Estevam wrote: > On Sat, Apr 1, 2017 at 1:15 AM, Stefan Agner wrote: > >> IMX7D_IPG_ROOT_CLK is currently not a valid clock in upstream... So we >> would have to add it to the clock driver first. >> >> I guess we could/should add it anyway at one point? But probably also as >> init on, just to make sure Linux does not disable it since it is >> currently used by several IPs implicitly. > > Yes, I made a previous attempt do add IMX7D_IPG_ROOT_CLK and it did > not work as I did not put it in the init_on clock list. > > Will submit a new patch adding it to init_on, thanks. I thought that adding IMX7D_IPG_ROOT_CLK would do the trick, but the patch below also causes the kernel to not boot: clks[IMX7D_CLKO2_ROOT_DIV] = imx_clk_divider2("clko2_post_div", "clko2_pre_div", base + 0xbe00, 0, 6); - + clks[IMX7D_IPG_ROOT_CLK] = imx_clk_divider2("ipg_root_clk", "ahb_root_clk", base + 0x9080, 0, 2); clks[IMX7D_ARM_A7_ROOT_CLK] = imx_clk_gate4("arm_a7_root_clk", "arm_a7_div", base + 0x4000, 0); clks[IMX7D_ARM_M4_ROOT_CLK] = imx_clk_gate4("arm_m4_root_clk", "arm_m4_div", base + 0x4010, 0); clks[IMX7D_ARM_M0_ROOT_CLK] = imx_clk_gate4("arm_m0_root_clk", "arm_m0_div", base + 0x4020, 0); --- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d.c @@ -386,7 +386,7 @@ static int const clks_init_on[] __initconst = { IMX7D_PLL_SYS_MAIN_480M_CLK, IMX7D_NAND_USDHC_BUS_ROOT_CLK, IMX7D_DRAM_PHYM_ROOT_CLK, IMX7D_DRAM_ROOT_CLK, IMX7D_DRAM_PHYM_ALT_ROOT_CLK, IMX7D_DRAM_ALT_ROOT_CLK, - IMX7D_AHB_CHANNEL_ROOT_CLK, + IMX7D_AHB_CHANNEL_ROOT_CLK, IMX7D_IPG_ROOT_CLK, }; static struct clk_onecell_data clk_data; @@ -788,7 +788,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) clks[IMX7D_WRCLK_ROOT_DIV] = imx_clk_divider2("wrclk_post_div", "wrclk_pre_div", base + 0xbd00, 0, 6); clks[IMX7D_CLKO1_ROOT_DIV] = imx_clk_divider2("clko1_post_div", "clko1_pre_div", base + 0xbd80, 0, 6);