[v4,0/3] Add support for x509 certs with NIST p256 and p192 keys

Message

Stefan Berger Jan. 28, 2021, 12:14 a.m. UTC

From: Stefan Berger <[e-mail]>

This series of patches adds support for x509 certificates signed by a CA
that uses NIST p256 or p192 keys for signing. It also adds support for
certificates where the public key is a NIST p256 or p192 key. The math
for ECDSA signature verification is also added.

Since self-signed certificates are verified upon loading, the following
script can be used for testing:

k=$(keyctl newring test @u)

while :; do
	for hash in sha1 sha224 sha256 sha384 sha512; do
		openssl req \
			-x509 \
			-${hash} \
			-newkey ec \
			-pkeyopt ec_paramgen_curve:prime256v1 \
			-keyout key.pem \
			-days 365 \
			-subj '/CN=test' \
			-nodes \
			-outform der \
			-out cert.der
		keyctl padd asymmetric testkey $k < cert.der
		if [ $? -ne 0 ]; then
			echo "ERROR"
			exit 1
		fi
	done
done

It also works with restricted keyrings where an RSA key is used to sign
a NIST P256/P192 key. Scripts for testing are here:

https://github.com/stefanberger/eckey-testing

The ECDSA signature verification will be used by IMA Appraisal where ECDSA
file signatures stored in RPM packages will use substantially less space
than if RSA signatures were to be used.

   Stefan

v3->v4:
  - split off of ecdsa crypto part; registering akcipher as "ecdsa" and
    deriving used curve from digits in parsed key

v2->v3:
  - patch 2 now includes linux/scatterlist.h

v1->v2:
  - using faster vli_sub rather than newly added vli_mod_fast to 'reduce'
    result
  - rearranged switch statements to follow after RSA
  - 3rd patch from 1st posting is now 1st patch


Stefan Berger (3):
  crypto: Add support for ECDSA signature verification
  x509: Detect sm2 keys by their parameters OID
  x509: Add support for parsing x509 certs with ECDSA keys

 crypto/Makefile                           |   9 +-
 crypto/asymmetric_keys/public_key.c       |  17 ++
 crypto/asymmetric_keys/x509_cert_parser.c |  45 +++-
 crypto/ecc.c                              | 279 ++++++++++++++++++++++
 crypto/ecc.h                              |   2 +
 crypto/ecdsasignature.asn1                |   4 +
 include/linux/oid_registry.h              |   6 +
 7 files changed, 359 insertions(+), 3 deletions(-)
 create mode 100644 crypto/ecdsasignature.asn1

Comments

David Howells Jan. 28, 2021, 9:19 a.m. UTC | #1

This (sub)set is intended to go through the keyrings tree or is it all going
through the crypto tree now?

David

Stefan Berger Jan. 28, 2021, 1:45 p.m. UTC | #2

On 1/28/21 4:19 AM, David Howells wrote:
> This (sub)set is intended to go through the keyrings tree or is it all going
> through the crypto tree now?


Patch 1/3 should go through 'crypto', the other ones through 'keyrings'.

    Stefan


>
> David
>

David Howells Jan. 28, 2021, 1:54 p.m. UTC | #3

Stefan Berger <[e-mail]> wrote:

> > This (sub)set is intended to go through the keyrings tree or is it all going
> > through the crypto tree now?
> 
> 
> Patch 1/3 should go through 'crypto', the other ones through 'keyrings'.

Do 2 & 3 depend on 1?

David

Stefan Berger Jan. 28, 2021, 1:58 p.m. UTC | #4

On 1/28/21 8:54 AM, David Howells wrote:
> Stefan Berger <[e-mail]> wrote:
>
>>> This (sub)set is intended to go through the keyrings tree or is it all going
>>> through the crypto tree now?
>>
>> Patch 1/3 should go through 'crypto', the other ones through 'keyrings'.
> Do 2 & 3 depend on 1?


Functionality-wise, yes, compilation-wise, no.

    Stefan