mbox series

[v3,0/2] crypto: arm - clean up redundant helper macros

Message ID 20210310101421.173689-1-ardb@kernel.org (mailing list archive)
Headers show
Series crypto: arm - clean up redundant helper macros | expand

Message

Ard Biesheuvel March 10, 2021, 10:14 a.m. UTC 
Now that ARM's asm/assembler.h provides mov_l and rev_l macros, let's get
rid of the locally defined ones that live in the ChaCha and AES crypto code.

Changes since v2:
- fix rev_32->rev_l in the patch subject lines
- add Eric's ack

Changes since v1:
- drop the patch that introduces rev_l, it has been merged in v5.12-rc
- rev_32 was renamed to rev_l, so both patches were updated to reflect that
- add acks from Nico, Geert and Linus

Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Nicolas Pitre <nico@fluxnic.net>
Cc: Eric Biggers <ebiggers@google.com>
Cc: Linus Walleij <linus.walleij@linaro.org>

Ard Biesheuvel (2):
  crypto: arm/aes-scalar - switch to common rev_l/mov_l macros
  crypto: arm/chacha-scalar - switch to common rev_l macro

 arch/arm/crypto/aes-cipher-core.S    | 42 +++++--------------
 arch/arm/crypto/chacha-scalar-core.S | 43 ++++++--------------
 2 files changed, 23 insertions(+), 62 deletions(-)

Comments

Herbert Xu March 19, 2021, 11:03 a.m. UTC | #1 
On Wed, Mar 10, 2021 at 11:14:19AM +0100, Ard Biesheuvel wrote:
> Now that ARM's asm/assembler.h provides mov_l and rev_l macros, let's get
> rid of the locally defined ones that live in the ChaCha and AES crypto code.
> 
> Changes since v2:
> - fix rev_32->rev_l in the patch subject lines
> - add Eric's ack
> 
> Changes since v1:
> - drop the patch that introduces rev_l, it has been merged in v5.12-rc
> - rev_32 was renamed to rev_l, so both patches were updated to reflect that
> - add acks from Nico, Geert and Linus
> 
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> Cc: Eric Biggers <ebiggers@google.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> 
> Ard Biesheuvel (2):
>   crypto: arm/aes-scalar - switch to common rev_l/mov_l macros
>   crypto: arm/chacha-scalar - switch to common rev_l macro
> 
>  arch/arm/crypto/aes-cipher-core.S    | 42 +++++--------------
>  arch/arm/crypto/chacha-scalar-core.S | 43 ++++++--------------
>  2 files changed, 23 insertions(+), 62 deletions(-)

All applied.  Thanks.