[RFT,0/5] crypto: rockchip: add crypto offloader V2

Message

Corentin LABBE Sept. 27, 2022, 8 a.m. UTC

Hello

Rockchip rk3568 and rk3588 have a common crypto offloader IP different
than rk3228 one.
I started to work the driver for this IP on a rk3588 based board, but this SoC
is still not upstream.
So it is why I send this serie asking for test since I own no rk3568 and
I need to be sure datasheet is right.

Note: I keeped all rk3588 reference intentionaly, but probably it will need to
be removed until this SoC was upstream.

Regards

Corentin Labbe (5):
  crypto: rockchip: move kconfig to its dedicated directory
  dt-bindings: crypto: add support for rockchip,crypto-rk3588
  MAINTAINERS: add new dt-binding doc to the right entry
  crypto: rockchip: support the new crypto IP for rk3568/rk3588
  ARM64: dts: rk3568: add crypto node

 .../crypto/rockchip,rk3588-crypto.yaml        |  71 ++
 MAINTAINERS                                   |   1 +
 arch/arm64/boot/dts/rockchip/rk3568.dtsi      |  14 +
 drivers/crypto/Kconfig                        |  32 +-
 drivers/crypto/Makefile                       |   2 +-
 drivers/crypto/rockchip/Kconfig               |  56 ++
 drivers/crypto/rockchip/Makefile              |   5 +
 drivers/crypto/rockchip/rk3588_crypto.c       | 646 ++++++++++++++++++
 drivers/crypto/rockchip/rk3588_crypto.h       | 221 ++++++
 drivers/crypto/rockchip/rk3588_crypto_ahash.c | 346 ++++++++++
 .../crypto/rockchip/rk3588_crypto_skcipher.c  | 340 +++++++++
 11 files changed, 1703 insertions(+), 31 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
 create mode 100644 drivers/crypto/rockchip/Kconfig
 create mode 100644 drivers/crypto/rockchip/rk3588_crypto.c
 create mode 100644 drivers/crypto/rockchip/rk3588_crypto.h
 create mode 100644 drivers/crypto/rockchip/rk3588_crypto_ahash.c
 create mode 100644 drivers/crypto/rockchip/rk3588_crypto_skcipher.c

Comments

Aurelien Jarno Sept. 27, 2022, 9:34 p.m. UTC | #1

On 2022-09-27 08:00, Corentin Labbe wrote:
> Hello
> 
> Rockchip rk3568 and rk3588 have a common crypto offloader IP different
> than rk3228 one.
> I started to work the driver for this IP on a rk3588 based board, but this SoC
> is still not upstream.
> So it is why I send this serie asking for test since I own no rk3568 and
> I need to be sure datasheet is right.

I did a quick test, and it doesn't seem to work. I get:

rk3588-crypto fe380000.crypto: DMA timeout
rk3588-crypto fe380000.crypto: DMA timeout

That's on an ODROID-M1 board, so with the set of patches I sent
yesterday to support it.

Corentin LABBE Sept. 29, 2022, 7:33 a.m. UTC | #2

Le Tue, Sep 27, 2022 at 11:34:58PM +0200, Aurelien Jarno a écrit :
> On 2022-09-27 08:00, Corentin Labbe wrote:
> > Hello
> > 
> > Rockchip rk3568 and rk3588 have a common crypto offloader IP different
> > than rk3228 one.
> > I started to work the driver for this IP on a rk3588 based board, but this SoC
> > is still not upstream.
> > So it is why I send this serie asking for test since I own no rk3568 and
> > I need to be sure datasheet is right.
> 
> I did a quick test, and it doesn't seem to work. I get:
> 
> rk3588-crypto fe380000.crypto: DMA timeout
> rk3588-crypto fe380000.crypto: DMA timeout
> 
> That's on an ODROID-M1 board, so with the set of patches I sent
> yesterday to support it.

Thanks for testing it, probably I did something wrong because I got a successfull test by someone on #linux-rockchip.
But I dont know on which board it is, and it was on my debug tree, so probably cleaned something wrong before sending the patchs.

If I sent you a link to my tree, could you retry ?

Regards

Aurelien Jarno Sept. 29, 2022, 8:33 p.m. UTC | #3

On 2022-09-29 09:33, LABBE Corentin wrote:
> Le Tue, Sep 27, 2022 at 11:34:58PM +0200, Aurelien Jarno a écrit :
> > On 2022-09-27 08:00, Corentin Labbe wrote:
> > > Hello
> > > 
> > > Rockchip rk3568 and rk3588 have a common crypto offloader IP different
> > > than rk3228 one.
> > > I started to work the driver for this IP on a rk3588 based board, but this SoC
> > > is still not upstream.
> > > So it is why I send this serie asking for test since I own no rk3568 and
> > > I need to be sure datasheet is right.
> > 
> > I did a quick test, and it doesn't seem to work. I get:
> > 
> > rk3588-crypto fe380000.crypto: DMA timeout
> > rk3588-crypto fe380000.crypto: DMA timeout
> > 
> > That's on an ODROID-M1 board, so with the set of patches I sent
> > yesterday to support it.
> 
> Thanks for testing it, probably I did something wrong because I got a successfull test by someone on #linux-rockchip.
> But I dont know on which board it is, and it was on my debug tree, so probably cleaned something wrong before sending the patchs.
> 
> If I sent you a link to my tree, could you retry ?

Yep, I can try that.

Regards
Aurelien