[v3,0/6] crypto: reduce overhead when self-tests disabled

Message

Eric Biggers Nov. 14, 2022, 12:12 a.m. UTC

This patchset makes it so that the self-test code doesn't still slow
things down when self-tests are disabled via the kconfig.

It also optimizes the registration of "internal" algorithms and silences
a noisy log message.

Changed in v3:
  - Made sure CRYPTO_MSG_ALG_LOADED still always gets sent.
  - Fixed a race condition with larval->test_started.
  - Used IS_ENABLED() in a couple places to avoid #ifdefs.

Eric Biggers (6):
  crypto: optimize algorithm registration when self-tests disabled
  crypto: optimize registration of internal algorithms
  crypto: compile out crypto_boot_test_finished when tests disabled
  crypto: skip kdf_sp800108 self-test when tests disabled
  crypto: silence noisy kdf_sp800108 self-test
  crypto: compile out test-related algboss code when tests disabled

 crypto/algapi.c       | 160 ++++++++++++++++++++++++------------------
 crypto/algboss.c      |  22 ++----
 crypto/api.c          |  11 ++-
 crypto/internal.h     |  20 +++++-
 crypto/kdf_sp800108.c |  10 ++-
 5 files changed, 127 insertions(+), 96 deletions(-)


base-commit: 557ffd5a4726f8b6f0dd1d4b632ae02c1c063233

Comments

Herbert Xu Nov. 25, 2022, 9:44 a.m. UTC | #1

Eric Biggers <[e-mail]> wrote:
> This patchset makes it so that the self-test code doesn't still slow
> things down when self-tests are disabled via the kconfig.
> 
> It also optimizes the registration of "internal" algorithms and silences
> a noisy log message.
> 
> Changed in v3:
>  - Made sure CRYPTO_MSG_ALG_LOADED still always gets sent.
>  - Fixed a race condition with larval->test_started.
>  - Used IS_ENABLED() in a couple places to avoid #ifdefs.
> 
> Eric Biggers (6):
>  crypto: optimize algorithm registration when self-tests disabled
>  crypto: optimize registration of internal algorithms
>  crypto: compile out crypto_boot_test_finished when tests disabled
>  crypto: skip kdf_sp800108 self-test when tests disabled
>  crypto: silence noisy kdf_sp800108 self-test
>  crypto: compile out test-related algboss code when tests disabled
> 
> crypto/algapi.c       | 160 ++++++++++++++++++++++++------------------
> crypto/algboss.c      |  22 ++----
> crypto/api.c          |  11 ++-
> crypto/internal.h     |  20 +++++-
> crypto/kdf_sp800108.c |  10 ++-
> 5 files changed, 127 insertions(+), 96 deletions(-)
> 
> 
> base-commit: 557ffd5a4726f8b6f0dd1d4b632ae02c1c063233

All applied.  Thanks.