| Message ID | 20221129190123.872394-1-nathan@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix lack of section mismatch warnings with LTO | expand |
On Tue, Nov 29, 2022 at 11:02 AM Nathan Chancellor <nathan@kernel.org> wrote: > > > Hi all, > > Vincent recently reported an issue with lack of section mismatch > warnings with LTO. This is due to commit 6c730bfc894f ("modpost: handle > -ffunction-sections"), which ignores all function sections for modpost. > > I believe this is incorrect, as these function sections may still refer > to symbols in other sections and they will ultimately be coalesced into > .text by vmlinux.lds anyways. > > The first patch fixes a warning that I see with allmodconfig + ThinLTO > builds after applying the second patch. The second patch moves ".text.*" > into TEXT_SECTIONS so that modpost audits them for mismatches. > > I expect this to go via the kbuild tree with an ack from the padata > maintainers. > > Cc: Steffen Klassert <steffen.klassert@secunet.com> > Cc: Daniel Jordan <daniel.m.jordan@oracle.com> > Cc: linux-crypto@vger.kernel.org > > Nathan Chancellor (2): > padata: Do not mark padata_mt_helper() as __init > modpost: Include '.text.*' in TEXT_SECTIONS > > kernel/padata.c | 4 ++-- > scripts/mod/modpost.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) These look good to me. Thanks for fixing the issue, Nathan! Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Sami
Hi all, Vincent recently reported an issue with lack of section mismatch warnings with LTO. This is due to commit 6c730bfc894f ("modpost: handle -ffunction-sections"), which ignores all function sections for modpost. I believe this is incorrect, as these function sections may still refer to symbols in other sections and they will ultimately be coalesced into .text by vmlinux.lds anyways. The first patch fixes a warning that I see with allmodconfig + ThinLTO builds after applying the second patch. The second patch moves ".text.*" into TEXT_SECTIONS so that modpost audits them for mismatches. I expect this to go via the kbuild tree with an ack from the padata maintainers. Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: Daniel Jordan <daniel.m.jordan@oracle.com> Cc: linux-crypto@vger.kernel.org Nathan Chancellor (2): padata: Do not mark padata_mt_helper() as __init modpost: Include '.text.*' in TEXT_SECTIONS kernel/padata.c | 4 ++-- scripts/mod/modpost.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) base-commit: b7b275e60bcd5f89771e865a8239325f86d9927d