From patchwork Tue Nov 29 19:01:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 13058995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DEFC4332F for ; Tue, 29 Nov 2022 19:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbiK2TCm (ORCPT ); Tue, 29 Nov 2022 14:02:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236394AbiK2TCU (ORCPT ); Tue, 29 Nov 2022 14:02:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0444BA1BD; Tue, 29 Nov 2022 11:02:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9371461874; Tue, 29 Nov 2022 19:02:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4124BC433C1; Tue, 29 Nov 2022 19:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669748526; bh=76rMPn3p1fYb/OlmUR+9LC3Aio6SHBw/oxeOcaAWk9w=; h=From:To:Cc:Subject:Date:From; b=KsKrOrONiEvlBlKvrXEX0OiVBSQotOXCPTrbKjOJbp/7GWjnAYrOgYffiJ2aEIY+i Tovr9GCVJ2wAVvUR8bCLWC8UxRb+hHm6wAJsXKOuTnsmDtDVQIdaC/Az60aSgN4JWt IWBseyS/WVHS6nJ9Lugdg52Iv8bQKgXnGPfO7GiqDR7u0DEDN4/ZtADZ0lxF77qTgL 3IJ1jie/n/iRcwcd01gIRCcjTW1BI7h/c431CXz0Kl/fmnqxzxnHCtSH5stwKVFoqH hFkye6zaTnM73DBTWqD78knjzqIY93eSq+VU9Ve/dJOs6g+3HvZ2ej7MtqfRiT3FGr 6/C0P/ac9EXyw== From: Nathan Chancellor To: Masahiro Yamada Cc: Nick Desaulniers , Tom Rix , Nicolas Schier , Sami Tolvanen , Vincent Donnefort , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, Nathan Chancellor , Steffen Klassert , Daniel Jordan , linux-crypto@vger.kernel.org Subject: [PATCH 0/2] Fix lack of section mismatch warnings with LTO Date: Tue, 29 Nov 2022 12:01:21 -0700 Message-Id: <20221129190123.872394-1-nathan@kernel.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi all, Vincent recently reported an issue with lack of section mismatch warnings with LTO. This is due to commit 6c730bfc894f ("modpost: handle -ffunction-sections"), which ignores all function sections for modpost. I believe this is incorrect, as these function sections may still refer to symbols in other sections and they will ultimately be coalesced into .text by vmlinux.lds anyways. The first patch fixes a warning that I see with allmodconfig + ThinLTO builds after applying the second patch. The second patch moves ".text.*" into TEXT_SECTIONS so that modpost audits them for mismatches. I expect this to go via the kbuild tree with an ack from the padata maintainers. Cc: Steffen Klassert Cc: Daniel Jordan Cc: linux-crypto@vger.kernel.org Nathan Chancellor (2): padata: Do not mark padata_mt_helper() as __init modpost: Include '.text.*' in TEXT_SECTIONS kernel/padata.c | 4 ++-- scripts/mod/modpost.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) base-commit: b7b275e60bcd5f89771e865a8239325f86d9927d Reviewed-by: Sami Tolvanen