mbox series

[0/2] crypto: qat - unmap buffers before free

Message ID 20230601101000.18293-1-giovanni.cabiddu@intel.com (mailing list archive)
Headers show
Series crypto: qat - unmap buffers before free | expand

Message

Cabiddu, Giovanni June 1, 2023, 10:09 a.m. UTC
The callbacks functions for RSA and DH free the memory allocated for the
source and destination buffers before unmapping it.
This sequence is not correct.

Change the cleanup sequence to unmap the buffers before freeing them.

Hareshx Sankar Raj (2):
  crypto: qat - unmap buffer before free for DH
  crypto: qat - unmap buffers before free for RSA

 .../crypto/intel/qat/qat_common/qat_asym_algs.c    | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

Comments

Cabiddu, Giovanni June 7, 2023, 8:01 a.m. UTC | #1
Hi Herbert,

On Thu, Jun 01, 2023 at 11:09:58AM +0100, Giovanni Cabiddu wrote:
> The callbacks functions for RSA and DH free the memory allocated for the
> source and destination buffers before unmapping it.
> This sequence is not correct.
> 
> Change the cleanup sequence to unmap the buffers before freeing them.
> 
> Hareshx Sankar Raj (2):
>   crypto: qat - unmap buffer before free for DH
>   crypto: qat - unmap buffers before free for RSA
> 
>  .../crypto/intel/qat/qat_common/qat_asym_algs.c    | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
Just in case you haven't seen it. There is a RESEND for the same set with
an additional Reviewed-by tag.

Regards,