| Message ID | 20240729041350.380633-1-pavitrakumarm@vayavyalabs.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add SPAcc Crypto Driver Support | expand |
On Mon, Jul 29, 2024 at 09:43:44AM +0530, Pavitrakumar M wrote: > Add the driver for SPAcc(Security Protocol Accelerator), which is a > crypto acceleration IP from Synopsys. The SPAcc supports many cipher, > hash, aead algorithms and various modes.The driver currently supports > below, > > aead: > - ccm(sm4) > - ccm(aes) > - gcm(sm4) > - gcm(aes) > - rfc7539(chacha20,poly1305) > > cipher: > - cbc(sm4) > - ecb(sm4) > - ctr(sm4) > - xts(sm4) > - cts(cbc(sm4)) > - cbc(aes) > - ecb(aes) > - xts(aes) > - cts(cbc(aes)) > - ctr(aes) > - chacha20 > - ecb(des) > - cbc(des) > - ecb(des3_ede) > - cbc(des3_ede) > > hash: > - cmac(aes) > - xcbc(aes) > - cmac(sm4) > - xcbc(sm4) > - hmac(md5) > - md5 > - hmac(sha1) > - sha1 > - sha224 > - sha256 > - sha384 > - sha512 > - hmac(sha224) > - hmac(sha256) > - hmac(sha384) > - hmac(sha512) > - sha3-224 > - sha3-256 > - sha3-384 > - sha3-512 > - hmac(sm3) > - sm3 > - michael_mic > > Pavitrakumar M (6): > Add SPAcc Skcipher support > Enable SPAcc AUTODETECT > Add SPAcc ahash support > Add SPAcc aead support > Add SPAcc Kconfig and Makefile > Enable Driver compilation in crypto Kconfig and Makefile > > drivers/crypto/Kconfig | 1 + > drivers/crypto/Makefile | 1 + > drivers/crypto/dwc-spacc/Kconfig | 95 + > drivers/crypto/dwc-spacc/Makefile | 16 + > drivers/crypto/dwc-spacc/spacc_aead.c | 1260 ++++++++++ > drivers/crypto/dwc-spacc/spacc_ahash.c | 914 +++++++ > drivers/crypto/dwc-spacc/spacc_core.c | 2512 ++++++++++++++++++++ > drivers/crypto/dwc-spacc/spacc_core.h | 826 +++++++ > drivers/crypto/dwc-spacc/spacc_device.c | 340 +++ > drivers/crypto/dwc-spacc/spacc_device.h | 231 ++ > drivers/crypto/dwc-spacc/spacc_hal.c | 367 +++ > drivers/crypto/dwc-spacc/spacc_hal.h | 114 + > drivers/crypto/dwc-spacc/spacc_interrupt.c | 316 +++ > drivers/crypto/dwc-spacc/spacc_manager.c | 650 +++++ > drivers/crypto/dwc-spacc/spacc_skcipher.c | 712 ++++++ > 15 files changed, 8355 insertions(+) > create mode 100644 drivers/crypto/dwc-spacc/Kconfig > create mode 100644 drivers/crypto/dwc-spacc/Makefile > create mode 100755 drivers/crypto/dwc-spacc/spacc_aead.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_ahash.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h > create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c > create mode 100644 drivers/crypto/dwc-spacc/spacc_skcipher.c > > > base-commit: 95c0f5c3b8bb7acdc5c4f04bc6a7d3f40d319e9e > -- > 2.25.1 All applied. Thanks.
On Sat, Aug 10, 2024 at 02:22:19PM +0800, Herbert Xu wrote: > On Mon, Jul 29, 2024 at 09:43:44AM +0530, Pavitrakumar M wrote: > > Add the driver for SPAcc(Security Protocol Accelerator), which is a > > crypto acceleration IP from Synopsys. The SPAcc supports many cipher, > > hash, aead algorithms and various modes.The driver currently supports > > below, > > > > aead: > > - ccm(sm4) > > - ccm(aes) > > - gcm(sm4) > > - gcm(aes) > > - rfc7539(chacha20,poly1305) > > > > cipher: > > - cbc(sm4) > > - ecb(sm4) > > - ctr(sm4) > > - xts(sm4) > > - cts(cbc(sm4)) > > - cbc(aes) > > - ecb(aes) > > - xts(aes) > > - cts(cbc(aes)) > > - ctr(aes) > > - chacha20 > > - ecb(des) > > - cbc(des) > > - ecb(des3_ede) > > - cbc(des3_ede) > > > > hash: > > - cmac(aes) > > - xcbc(aes) > > - cmac(sm4) > > - xcbc(sm4) > > - hmac(md5) > > - md5 > > - hmac(sha1) > > - sha1 > > - sha224 > > - sha256 > > - sha384 > > - sha512 > > - hmac(sha224) > > - hmac(sha256) > > - hmac(sha384) > > - hmac(sha512) > > - sha3-224 > > - sha3-256 > > - sha3-384 > > - sha3-512 > > - hmac(sm3) > > - sm3 > > - michael_mic > > > > Pavitrakumar M (6): > > Add SPAcc Skcipher support > > Enable SPAcc AUTODETECT > > Add SPAcc ahash support > > Add SPAcc aead support > > Add SPAcc Kconfig and Makefile > > Enable Driver compilation in crypto Kconfig and Makefile > > > > drivers/crypto/Kconfig | 1 + > > drivers/crypto/Makefile | 1 + > > drivers/crypto/dwc-spacc/Kconfig | 95 + > > drivers/crypto/dwc-spacc/Makefile | 16 + > > drivers/crypto/dwc-spacc/spacc_aead.c | 1260 ++++++++++ > > drivers/crypto/dwc-spacc/spacc_ahash.c | 914 +++++++ > > drivers/crypto/dwc-spacc/spacc_core.c | 2512 ++++++++++++++++++++ > > drivers/crypto/dwc-spacc/spacc_core.h | 826 +++++++ > > drivers/crypto/dwc-spacc/spacc_device.c | 340 +++ > > drivers/crypto/dwc-spacc/spacc_device.h | 231 ++ > > drivers/crypto/dwc-spacc/spacc_hal.c | 367 +++ > > drivers/crypto/dwc-spacc/spacc_hal.h | 114 + > > drivers/crypto/dwc-spacc/spacc_interrupt.c | 316 +++ > > drivers/crypto/dwc-spacc/spacc_manager.c | 650 +++++ > > drivers/crypto/dwc-spacc/spacc_skcipher.c | 712 ++++++ > > 15 files changed, 8355 insertions(+) > > create mode 100644 drivers/crypto/dwc-spacc/Kconfig > > create mode 100644 drivers/crypto/dwc-spacc/Makefile > > create mode 100755 drivers/crypto/dwc-spacc/spacc_aead.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_ahash.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h > > create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c > > create mode 100644 drivers/crypto/dwc-spacc/spacc_skcipher.c > > > > > > base-commit: 95c0f5c3b8bb7acdc5c4f04bc6a7d3f40d319e9e > > -- > > 2.25.1 > > All applied. Thanks. Please drop it. Amongst other problems I pointed out in patch, there's no binding for this nor will one be accepted as-is. The author has had 2 weeks to address it. Rob
On Tue, Sep 03, 2024 at 12:25:09PM -0500, Rob Herring wrote: > On Sat, Aug 10, 2024 at 02:22:19PM +0800, Herbert Xu wrote: > > On Mon, Jul 29, 2024 at 09:43:44AM +0530, Pavitrakumar M wrote: > > > Add the driver for SPAcc(Security Protocol Accelerator), which is a > > > crypto acceleration IP from Synopsys. The SPAcc supports many cipher, > > > hash, aead algorithms and various modes.The driver currently supports > > > below, > > > > > > aead: > > > - ccm(sm4) > > > - ccm(aes) > > > - gcm(sm4) > > > - gcm(aes) > > > - rfc7539(chacha20,poly1305) > > > > > > cipher: > > > - cbc(sm4) > > > - ecb(sm4) > > > - ctr(sm4) > > > - xts(sm4) > > > - cts(cbc(sm4)) > > > - cbc(aes) > > > - ecb(aes) > > > - xts(aes) > > > - cts(cbc(aes)) > > > - ctr(aes) > > > - chacha20 > > > - ecb(des) > > > - cbc(des) > > > - ecb(des3_ede) > > > - cbc(des3_ede) > > > > > > hash: > > > - cmac(aes) > > > - xcbc(aes) > > > - cmac(sm4) > > > - xcbc(sm4) > > > - hmac(md5) > > > - md5 > > > - hmac(sha1) > > > - sha1 > > > - sha224 > > > - sha256 > > > - sha384 > > > - sha512 > > > - hmac(sha224) > > > - hmac(sha256) > > > - hmac(sha384) > > > - hmac(sha512) > > > - sha3-224 > > > - sha3-256 > > > - sha3-384 > > > - sha3-512 > > > - hmac(sm3) > > > - sm3 > > > - michael_mic > > > > > > Pavitrakumar M (6): > > > Add SPAcc Skcipher support > > > Enable SPAcc AUTODETECT > > > Add SPAcc ahash support > > > Add SPAcc aead support > > > Add SPAcc Kconfig and Makefile > > > Enable Driver compilation in crypto Kconfig and Makefile > > > > > > drivers/crypto/Kconfig | 1 + > > > drivers/crypto/Makefile | 1 + > > > drivers/crypto/dwc-spacc/Kconfig | 95 + > > > drivers/crypto/dwc-spacc/Makefile | 16 + > > > drivers/crypto/dwc-spacc/spacc_aead.c | 1260 ++++++++++ > > > drivers/crypto/dwc-spacc/spacc_ahash.c | 914 +++++++ > > > drivers/crypto/dwc-spacc/spacc_core.c | 2512 ++++++++++++++++++++ > > > drivers/crypto/dwc-spacc/spacc_core.h | 826 +++++++ > > > drivers/crypto/dwc-spacc/spacc_device.c | 340 +++ > > > drivers/crypto/dwc-spacc/spacc_device.h | 231 ++ > > > drivers/crypto/dwc-spacc/spacc_hal.c | 367 +++ > > > drivers/crypto/dwc-spacc/spacc_hal.h | 114 + > > > drivers/crypto/dwc-spacc/spacc_interrupt.c | 316 +++ > > > drivers/crypto/dwc-spacc/spacc_manager.c | 650 +++++ > > > drivers/crypto/dwc-spacc/spacc_skcipher.c | 712 ++++++ > > > 15 files changed, 8355 insertions(+) > > > create mode 100644 drivers/crypto/dwc-spacc/Kconfig > > > create mode 100644 drivers/crypto/dwc-spacc/Makefile > > > create mode 100755 drivers/crypto/dwc-spacc/spacc_aead.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_ahash.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_skcipher.c > > > > > > > > > base-commit: 95c0f5c3b8bb7acdc5c4f04bc6a7d3f40d319e9e > > > -- > > > 2.25.1 > > > > All applied. Thanks. > > Please drop it. Amongst other problems I pointed out in patch, there's > no binding for this nor will one be accepted as-is. The author has had 2 > weeks to address it. OK I will revert this. Cheers,
Herbert, I am pushing the DT bindings and all the DT changes that Rob has asked in driver. We had a crash with the changes in counter mode, we were root causing that. The dealy was because of that. I am pushing the incremental patch. Please review it if the driver it not reverted yet. Warm regards, Pavitrakumar On Wed, Sep 4, 2024 at 4:29 AM Herbert Xu <herbert@gondor.apana.org.au> wrote: > > On Tue, Sep 03, 2024 at 12:25:09PM -0500, Rob Herring wrote: > > On Sat, Aug 10, 2024 at 02:22:19PM +0800, Herbert Xu wrote: > > > On Mon, Jul 29, 2024 at 09:43:44AM +0530, Pavitrakumar M wrote: > > > > Add the driver for SPAcc(Security Protocol Accelerator), which is a > > > > crypto acceleration IP from Synopsys. The SPAcc supports many cipher, > > > > hash, aead algorithms and various modes.The driver currently supports > > > > below, > > > > > > > > aead: > > > > - ccm(sm4) > > > > - ccm(aes) > > > > - gcm(sm4) > > > > - gcm(aes) > > > > - rfc7539(chacha20,poly1305) > > > > > > > > cipher: > > > > - cbc(sm4) > > > > - ecb(sm4) > > > > - ctr(sm4) > > > > - xts(sm4) > > > > - cts(cbc(sm4)) > > > > - cbc(aes) > > > > - ecb(aes) > > > > - xts(aes) > > > > - cts(cbc(aes)) > > > > - ctr(aes) > > > > - chacha20 > > > > - ecb(des) > > > > - cbc(des) > > > > - ecb(des3_ede) > > > > - cbc(des3_ede) > > > > > > > > hash: > > > > - cmac(aes) > > > > - xcbc(aes) > > > > - cmac(sm4) > > > > - xcbc(sm4) > > > > - hmac(md5) > > > > - md5 > > > > - hmac(sha1) > > > > - sha1 > > > > - sha224 > > > > - sha256 > > > > - sha384 > > > > - sha512 > > > > - hmac(sha224) > > > > - hmac(sha256) > > > > - hmac(sha384) > > > > - hmac(sha512) > > > > - sha3-224 > > > > - sha3-256 > > > > - sha3-384 > > > > - sha3-512 > > > > - hmac(sm3) > > > > - sm3 > > > > - michael_mic > > > > > > > > Pavitrakumar M (6): > > > > Add SPAcc Skcipher support > > > > Enable SPAcc AUTODETECT > > > > Add SPAcc ahash support > > > > Add SPAcc aead support > > > > Add SPAcc Kconfig and Makefile > > > > Enable Driver compilation in crypto Kconfig and Makefile > > > > > > > > drivers/crypto/Kconfig | 1 + > > > > drivers/crypto/Makefile | 1 + > > > > drivers/crypto/dwc-spacc/Kconfig | 95 + > > > > drivers/crypto/dwc-spacc/Makefile | 16 + > > > > drivers/crypto/dwc-spacc/spacc_aead.c | 1260 ++++++++++ > > > > drivers/crypto/dwc-spacc/spacc_ahash.c | 914 +++++++ > > > > drivers/crypto/dwc-spacc/spacc_core.c | 2512 ++++++++++++++++++++ > > > > drivers/crypto/dwc-spacc/spacc_core.h | 826 +++++++ > > > > drivers/crypto/dwc-spacc/spacc_device.c | 340 +++ > > > > drivers/crypto/dwc-spacc/spacc_device.h | 231 ++ > > > > drivers/crypto/dwc-spacc/spacc_hal.c | 367 +++ > > > > drivers/crypto/dwc-spacc/spacc_hal.h | 114 + > > > > drivers/crypto/dwc-spacc/spacc_interrupt.c | 316 +++ > > > > drivers/crypto/dwc-spacc/spacc_manager.c | 650 +++++ > > > > drivers/crypto/dwc-spacc/spacc_skcipher.c | 712 ++++++ > > > > 15 files changed, 8355 insertions(+) > > > > create mode 100644 drivers/crypto/dwc-spacc/Kconfig > > > > create mode 100644 drivers/crypto/dwc-spacc/Makefile > > > > create mode 100755 drivers/crypto/dwc-spacc/spacc_aead.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_ahash.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c > > > > create mode 100644 drivers/crypto/dwc-spacc/spacc_skcipher.c > > > > > > > > > > > > base-commit: 95c0f5c3b8bb7acdc5c4f04bc6a7d3f40d319e9e > > > > -- > > > > 2.25.1 > > > > > > All applied. Thanks. > > > > Please drop it. Amongst other problems I pointed out in patch, there's > > no binding for this nor will one be accepted as-is. The author has had 2 > > weeks to address it. > > OK I will revert this. > > Cheers, > -- > Email: Herbert Xu <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Sep 04, 2024 at 08:22:31AM +0530, Pavitrakumar Managutte wrote: > Herbert, > I am pushing the DT bindings. > We had a crash with the changes, we were root causing those. > Should I push the whole driver once again or should I push just the > incremental patches? You will need to start again from scratch. Please make sure that you include all the fixes that have been posted. Thanks,
Sure Herbert, I have the driver with all the fixes merged and DT fixes asked by Rob. I will add the DT bindings to the same patchset and push it immediately. Warm Regards, PK On Wed, Sep 4, 2024 at 8:38 AM Herbert Xu <herbert@gondor.apana.org.au> wrote: > > On Wed, Sep 04, 2024 at 08:22:31AM +0530, Pavitrakumar Managutte wrote: > > Herbert, > > I am pushing the DT bindings. > > We had a crash with the changes, we were root causing those. > > Should I push the whole driver once again or should I push just the > > incremental patches? > > You will need to start again from scratch. Please make sure > that you include all the fixes that have been posted. > > Thanks, > -- > Email: Herbert Xu <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Sep 04, 2024 at 08:24:42AM +0530, Pavitrakumar Managutte wrote: > I am pushing the incremental patch. Please review it if the driver > it not reverted yet. Sorry, the driver has already been reverted so you will need to repost the whole thing with bindings. Thanks,
Hi Herbert, I have pushed the SPAcc driver patches and the SPAcc DT bindings as a separate patch. I have pulled in all the fixes which had been merged. Requesting a review. Warm regards, PK On Wed, Sep 4, 2024 at 9:11 AM Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com> wrote: > > Hi Herbert, > I am pushing all the driver patches again (with the merged fixes) and with the DT bindings. > > Warm Regards, > PK > > > > On Wed, Sep 4, 2024 at 8:59 AM Herbert Xu <herbert@gondor.apana.org.au> wrote: >> >> On Wed, Sep 04, 2024 at 08:24:42AM +0530, Pavitrakumar Managutte wrote: >> > I am pushing the incremental patch. Please review it if the driver >> > it not reverted yet. >> >> Sorry, the driver has already been reverted so you will need to >> repost the whole thing with bindings. >> >> Thanks, >> -- >> Email: Herbert Xu <herbert@gondor.apana.org.au> >> Home Page: http://gondor.apana.org.au/~herbert/ >> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt