| Message ID | cover.1561360551.git.christophe.leroy@c-s.fr (mailing list archive) |
|---|---|
| Headers | show |
| Series | *** SUBJECT HERE *** | expand |
Hi Herbert, Le 24/06/2019 à 09:21, Christophe Leroy a écrit : > This series is the last set of fixes for the Talitos driver. Do you plan to apply this series, or are you expecting anythink from myself ? Thanks Christophe > > We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and > SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: > > [ 3.385197] bus: 'platform': really_probe: probing driver talitos with device ff020000.crypto > [ 3.450982] random: fast init done > [ 12.252548] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) > [ 12.262226] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) > [ 43.310737] Bug in SEC1, padding ourself > [ 45.603318] random: crng init done > [ 54.612333] talitos ff020000.crypto: fsl,sec1.2 algorithms registered in /proc/crypto > [ 54.620232] driver: 'talitos': driver_bound: bound to device 'ff020000.crypto' > > [ 1.193721] bus: 'platform': really_probe: probing driver talitos with device b0030000.crypto > [ 1.229197] random: fast init done > [ 2.714920] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos) > [ 2.724312] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos-hsna) > [ 4.482045] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos) > [ 4.490940] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) > [ 4.500280] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos) > [ 4.509727] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) > [ 6.631781] random: crng init done > [ 11.521795] talitos b0030000.crypto: fsl,sec2.2 algorithms registered in /proc/crypto > [ 11.529803] driver: 'talitos': driver_bound: bound to device 'b0030000.crypto' > > v2: dropped patch 1 which was irrelevant due to a rebase weirdness. Added Cc to stable on the 2 first patches. > > v3: > - removed stable reference in patch 1 > - reworded patch 1 to include name of patch 2 for the dependency. > - mentionned this dependency in patch 2 as well. > - corrected the Fixes: sha1 in patch 4 > > v4: > - using scatterwalk_ffwd() instead of opencodying SG list forwarding. > - Added a patch to fix sg_copy_to_buffer() when sg->offset() is greater than PAGE_SIZE, > otherwise sg_copy_to_buffer() fails when the list has been forwarded with scatterwalk_ffwd(). > - taken the patch "crypto: talitos - eliminate unneeded 'done' functions at build time" > out of the series because it is independent. > - added a helper to find the header field associated to a request in flush_channe() > > v5: > - Replacing the while loop by a direct shift/mask operation, as suggested by Herbert in patch 1. > > Christophe Leroy (4): > lib/scatterlist: Fix mapping iterator when sg->offset is greater than > PAGE_SIZE > crypto: talitos - move struct talitos_edesc into talitos.h > crypto: talitos - fix hash on SEC1. > crypto: talitos - drop icv_ool > > drivers/crypto/talitos.c | 102 +++++++++++++++++++---------------------------- > drivers/crypto/talitos.h | 28 +++++++++++++ > lib/scatterlist.c | 9 +++-- > 3 files changed, 74 insertions(+), 65 deletions(-) >
On Mon, Jun 24, 2019 at 07:20:13AM +0000, Christophe Leroy wrote: > This series is the last set of fixes for the Talitos driver. > > We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and > SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: > > [ 3.385197] bus: 'platform': really_probe: probing driver talitos with device ff020000.crypto > [ 3.450982] random: fast init done > [ 12.252548] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) > [ 12.262226] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) > [ 43.310737] Bug in SEC1, padding ourself > [ 45.603318] random: crng init done > [ 54.612333] talitos ff020000.crypto: fsl,sec1.2 algorithms registered in /proc/crypto > [ 54.620232] driver: 'talitos': driver_bound: bound to device 'ff020000.crypto' > > [ 1.193721] bus: 'platform': really_probe: probing driver talitos with device b0030000.crypto > [ 1.229197] random: fast init done > [ 2.714920] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos) > [ 2.724312] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos-hsna) > [ 4.482045] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos) > [ 4.490940] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) > [ 4.500280] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos) > [ 4.509727] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) > [ 6.631781] random: crng init done > [ 11.521795] talitos b0030000.crypto: fsl,sec2.2 algorithms registered in /proc/crypto > [ 11.529803] driver: 'talitos': driver_bound: bound to device 'b0030000.crypto' > > v2: dropped patch 1 which was irrelevant due to a rebase weirdness. Added Cc to stable on the 2 first patches. > > v3: > - removed stable reference in patch 1 > - reworded patch 1 to include name of patch 2 for the dependency. > - mentionned this dependency in patch 2 as well. > - corrected the Fixes: sha1 in patch 4 > > v4: > - using scatterwalk_ffwd() instead of opencodying SG list forwarding. > - Added a patch to fix sg_copy_to_buffer() when sg->offset() is greater than PAGE_SIZE, > otherwise sg_copy_to_buffer() fails when the list has been forwarded with scatterwalk_ffwd(). > - taken the patch "crypto: talitos - eliminate unneeded 'done' functions at build time" > out of the series because it is independent. > - added a helper to find the header field associated to a request in flush_channe() > > v5: > - Replacing the while loop by a direct shift/mask operation, as suggested by Herbert in patch 1. > > Christophe Leroy (4): > lib/scatterlist: Fix mapping iterator when sg->offset is greater than > PAGE_SIZE > crypto: talitos - move struct talitos_edesc into talitos.h > crypto: talitos - fix hash on SEC1. > crypto: talitos - drop icv_ool > > drivers/crypto/talitos.c | 102 +++++++++++++++++++---------------------------- > drivers/crypto/talitos.h | 28 +++++++++++++ > lib/scatterlist.c | 9 +++-- > 3 files changed, 74 insertions(+), 65 deletions(-) All applied. Thanks.
This series is the last set of fixes for the Talitos driver. We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: [ 3.385197] bus: 'platform': really_probe: probing driver talitos with device ff020000.crypto [ 3.450982] random: fast init done [ 12.252548] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) [ 12.262226] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) [ 43.310737] Bug in SEC1, padding ourself [ 45.603318] random: crng init done [ 54.612333] talitos ff020000.crypto: fsl,sec1.2 algorithms registered in /proc/crypto [ 54.620232] driver: 'talitos': driver_bound: bound to device 'ff020000.crypto' [ 1.193721] bus: 'platform': really_probe: probing driver talitos with device b0030000.crypto [ 1.229197] random: fast init done [ 2.714920] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos) [ 2.724312] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos-hsna) [ 4.482045] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos) [ 4.490940] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) [ 4.500280] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos) [ 4.509727] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) [ 6.631781] random: crng init done [ 11.521795] talitos b0030000.crypto: fsl,sec2.2 algorithms registered in /proc/crypto [ 11.529803] driver: 'talitos': driver_bound: bound to device 'b0030000.crypto' v2: dropped patch 1 which was irrelevant due to a rebase weirdness. Added Cc to stable on the 2 first patches. v3: - removed stable reference in patch 1 - reworded patch 1 to include name of patch 2 for the dependency. - mentionned this dependency in patch 2 as well. - corrected the Fixes: sha1 in patch 4 v4: - using scatterwalk_ffwd() instead of opencodying SG list forwarding. - Added a patch to fix sg_copy_to_buffer() when sg->offset() is greater than PAGE_SIZE, otherwise sg_copy_to_buffer() fails when the list has been forwarded with scatterwalk_ffwd(). - taken the patch "crypto: talitos - eliminate unneeded 'done' functions at build time" out of the series because it is independent. - added a helper to find the header field associated to a request in flush_channe() v5: - Replacing the while loop by a direct shift/mask operation, as suggested by Herbert in patch 1. Christophe Leroy (4): lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE crypto: talitos - move struct talitos_edesc into talitos.h crypto: talitos - fix hash on SEC1. crypto: talitos - drop icv_ool drivers/crypto/talitos.c | 102 +++++++++++++++++++---------------------------- drivers/crypto/talitos.h | 28 +++++++++++++ lib/scatterlist.c | 9 +++-- 3 files changed, 74 insertions(+), 65 deletions(-)