From patchwork Sun Jul 21 00:46:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 13737928 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4404010E3; Sun, 21 Jul 2024 00:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721522846; cv=none; b=EPeGPlPURH+BnqCiXMoSwaCHZjmAX3B+qW2L8d+8yIMe23t6spQBbgNFqTSPuRyQVlp54d2NZ9qPZKgLtERGciFoomHZi9Ox82cxWWRLZCYOmDPY32qV1B2QHaQlx74tIWDRPgYnhYz126mMKG9kkhm+KOiTPFpnrpBfMWp5K6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721522846; c=relaxed/simple; bh=A1uSQrISbjC31vxVCG7WJK5khbIJqwlX8eA146M7y0s=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=XOk0FIjNK/R/7Vawlg6tqPRiMsU2iYKUVIBxerEazJfkCf1719icKFpAMV6MrPClrh0/PYiDWjEOCTkquzL7cQoVPFWqxqhvRd9x8rgN165YaYcnAhmCcD2AwmSOgPfUOL4jr0UPbDnBwVt1i1oIv3dWFGlEEPmCJNmaPbhQ67g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98) (envelope-from ) id 1sVKiv-000000007PR-2TPE; Sun, 21 Jul 2024 00:46:49 +0000 Date: Sun, 21 Jul 2024 01:46:45 +0100 From: Daniel Golle To: Daniel Golle , Aurelien Jarno , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Dragan Simic , Uwe =?iso-8859-1?q?Kleine-K=F6nig?= , Sascha Hauer , Cristian Ciocaltea , Martin Kaiser , Francesco Dolcini , Ard Biesheuvel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 0/3] hwrng: add hwrng support for Rockchip RK3568 Message-ID: Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Rockchip SoCs used to have a random number generator as part of their crypto device. However newer Rockchip SoCs like the RK3568 have an independent True Random Number Generator device. This patchset adds a driver for it and enables it in the device tree for RTK3568. Tested on FriendlyARM NanoPi R5C. v7 -> v8: * Patch 1: document new properties - introduce 'rockchip,sample-count' - require to specify 'quality' (0~1024) * Patch 2: - read sample-count and quality from DT * Patch 3: - disable hwrng in rk356x.dtsi, enable only in rk3568.dtsi - set sample-count 1000 and quality 900 (87.9%) as before v6 -> v7: * Patch 1: unchanged * Patch 2: bring back rk_rng_write_ctl() - bring back rk_rng_write_ctl() with improved comment to describe the hardware. * Patch 3: unchaned v5 -> v6: * Patch 1: unchanged * Patch 2: get rid of #ifdef - use if (IS_ENABLED(...)) { ... }instead of #ifdef inside functions - use __maybe_unused for functions previously enclosed by #ifdef'ery * Patch 3: unchanged v4 -> v5: * Patch 1: always use RK3568 name - use full RK3568 name in patch description - add RK3568 to title in binding * Patch 2: full name and cosmetics - also always mention RK3568 as there may be other RNG in other (future) Rockchip SoCs - remove debug output on successful probe - use MODULE_AUTHOR several times instead of single comma-separated * Patch 3: unchanged v3 -> v4: * Patch 1: minor corrections - fix Rokchip -> Rockchip typo - change commit title as requested * Patch 2: improved error handling and resource management - Always use writel() instead of writel_relaxed() - Use pm_runtime_resume_and_get - Correctly return error code in rk_rng_read() - Make use of devm_reset_control_array_get_exclusive - Use devm_pm_runtime_enable and there by get rid of rk_rng_remove() * Patch 3: - Move node to conform with ordering by address v2 -> v3: patch adopted by Daniel Golle * Patch 1: address comments of Krzysztof Kozlowski, add MAINTAINERS - improved description - meaningful clock-names - add entry in MAINTAINERS files * Patch 2: numerous code-style improvements - drop misleading rk_rng_write_ctl(), simplify I/O writes - drop unused TRNG_RNG_DOUT_[1-7] macros - handle error handling for pm_runtime_get_sync() - use memcpy_fromio() instead of open coding for-loop - some minor white-spaces fixes * Patch 3: - use clock-names as defined in dt-bindings v1 -> v2: * Patch 1: fix issues reported by Rob Herring and Krzysztof Kozlowski: - Rename rockchip-rng.yaml into rockchip,rk3568-rng.yaml - Fix binding title and description - Fix compatible property - Rename clocks and add the corresponding descriptions - Drop reset-names - Add a bus definition with #address-cells and #size-cells to the example. * Patch 2: fix issue reported by kernel test robot - Do not read the random registers as big endian, looking at the RK3568 TRM this is actually not needed. This fixes a sparse warning. * Patch 3: unchanged Aurelien Jarno (3): dt-bindings: rng: Add Rockchip RK3568 TRNG hwrng: add hwrng driver for Rockchip RK3568 SoC arm64: dts: rockchip: add DT entry for RNG to RK356x .../bindings/rng/rockchip,rk3568-rng.yaml | 82 +++++++ MAINTAINERS | 7 + arch/arm64/boot/dts/rockchip/rk3568.dtsi | 7 + arch/arm64/boot/dts/rockchip/rk356x.dtsi | 10 + drivers/char/hw_random/Kconfig | 14 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/rockchip-rng.c | 230 ++++++++++++++++++ 7 files changed, 351 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml create mode 100644 drivers/char/hw_random/rockchip-rng.c