From patchwork Sat Jul 14 00:20:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Logan Gunthorpe X-Patchwork-Id: 10524285 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5ABEF602B3 for ; Sat, 14 Jul 2018 00:20:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 459182948C for ; Sat, 14 Jul 2018 00:20:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3699B29560; Sat, 14 Jul 2018 00:20:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0FDB2948C for ; Sat, 14 Jul 2018 00:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731383AbeGNAhW (ORCPT ); Fri, 13 Jul 2018 20:37:22 -0400 Received: from ale.deltatee.com ([207.54.116.67]:48772 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731264AbeGNAhW (ORCPT ); Fri, 13 Jul 2018 20:37:22 -0400 Received: from s0106602ad0811846.cg.shawcable.net ([68.147.191.165] helo=[192.168.0.18]) by ale.deltatee.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1fe8I9-0002fO-1Y; Fri, 13 Jul 2018 18:20:05 -0600 To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-crypto@vger.kernel.org, Andrew Morton , Arnd Bergmann , Greg Kroah-Hartman , Andy Shevchenko , =?UTF-8?Q?Horia_Geant=c4=83?= , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Suresh Warrier , Nicholas Piggin References: <20180622194752.11221-4-logang@deltatee.com> <20180713233831.GA2946@roeck-us.net> From: Logan Gunthorpe Message-ID: <0a32dbb8-a1fa-f691-1d4a-9851b1496b9a@deltatee.com> Date: Fri, 13 Jul 2018 18:20:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180713233831.GA2946@roeck-us.net> Content-Language: en-US X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: npiggin@gmail.com, warrier@linux.vnet.ibm.com, mpe@ellerman.id.au, paulus@samba.org, benh@kernel.crashing.org, horia.geanta@nxp.com, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, arnd@arndb.de, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, linux-ntb@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [v18,3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo} X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 13/07/18 05:38 PM, Guenter Roeck wrote: > This patch causes a build failure in -next when building > ppc:corenet64_smp_defconfig. Thanks for the report. This 64bit IO stuff is a bit of a mess. It looks like your corner case arch and config was never covered by the kbuild robot which has run extensively on this patchset. Anyway, I think the fix is to put back the ioread64/write64 prototypes (even though they are only used in this one corner). Can you try it with the following patch to ensure it fixes things for you? Logan diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h index 5a4af0199b32..9f11a79e0d7a 100644 --- a/include/asm-generic/iomap.h +++ b/include/asm-generic/iomap.h @@ -32,6 +32,11 @@ extern unsigned int ioread16be(void __iomem *); extern unsigned int ioread32(void __iomem *); extern unsigned int ioread32be(void __iomem *); +#ifdef CONFIG_64BIT +extern u64 ioread64(void __iomem *); +extern u64 ioread64be(void __iomem *); +#endif + #ifdef readq #define ioread64_lo_hi ioread64_lo_hi #define ioread64_hi_lo ioread64_hi_lo @@ -49,6 +54,11 @@ extern void iowrite16be(u16, void __iomem *); extern void iowrite32(u32, void __iomem *); extern void iowrite32be(u32, void __iomem *); +#ifdef CONFIG_64BIT +extern void iowrite64(u64, void __iomem *); +extern void iowrite64be(u64, void __iomem *); +#endif + #ifdef writeq #define iowrite64_lo_hi iowrite64_lo_hi #define iowrite64_hi_lo iowrite64_hi_lo