| Message ID | 1439521558-17214-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
On Fri, Aug 14, 2015 at 12:05:58AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Compare pointer-typed values to NULL rather than 0. > > The semantic patch that makes this change is available > in scripts/coccinelle/null/badzero.cocci > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/crypto/amcc/crypto4xx_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c > index 3b28e8c..47c4b08 100644 > --- a/drivers/crypto/amcc/crypto4xx_core.c > +++ b/drivers/crypto/amcc/crypto4xx_core.c > @@ -1113,7 +1113,7 @@ static irqreturn_t crypto4xx_ce_interrupt_handler(int irq, void *data) > struct device *dev = (struct device *)data; > struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev); > > - if (core_dev->dev->ce_base == 0) > + if (core_dev->dev->ce_base == NULL) Please use ! instead. Thanks,
diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 3b28e8c..47c4b08 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1113,7 +1113,7 @@ static irqreturn_t crypto4xx_ce_interrupt_handler(int irq, void *data) struct device *dev = (struct device *)data; struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev); - if (core_dev->dev->ce_base == 0) + if (core_dev->dev->ce_base == NULL) return 0; writel(PPC4XX_INTERRUPT_CLR,