diff mbox

crypto: brcm - Fix SHA3-512 algorithm failure

Message ID 1498200347-14580-1-git-send-email-raveendra.padasalagi@broadcom.com (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show

Commit Message

Raveendra Padasalagi June 23, 2017, 6:45 a.m. UTC 
In Broadcom SPU driver, due to missing break statement
in spu2_hash_xlate() while mapping SPU2 equivalent
SHA3-512 value, -EINVAL is chosen and hence leading to
failure of SHA3-512 algorithm. This patch fixes the same.

Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
 drivers/crypto/bcm/spu2.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anup Patel June 23, 2017, 8:33 a.m. UTC | #1 
On Fri, Jun 23, 2017 at 12:15 PM, Raveendra Padasalagi
<raveendra.padasalagi@broadcom.com> wrote:
> In Broadcom SPU driver, due to missing break statement
> in spu2_hash_xlate() while mapping SPU2 equivalent
> SHA3-512 value, -EINVAL is chosen and hence leading to
> failure of SHA3-512 algorithm. This patch fixes the same.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  drivers/crypto/bcm/spu2.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c
> index ef04c97..bf7ac62 100644
> --- a/drivers/crypto/bcm/spu2.c
> +++ b/drivers/crypto/bcm/spu2.c
> @@ -302,6 +302,7 @@ static int spu2_hash_mode_xlate(enum hash_mode hash_mode,
>                 break;
>         case HASH_ALG_SHA3_512:
>                 *spu2_type = SPU2_HASH_TYPE_SHA3_512;
> +               break;
>         case HASH_ALG_LAST:
>         default:
>                 err = -EINVAL;
> --
> 1.9.1
>

This should go in linux-stable too.

Please CC Linux stable and include "Fixes:".

Regards,
Anup
diff mbox

Patch

diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c
index ef04c97..bf7ac62 100644
--- a/drivers/crypto/bcm/spu2.c
+++ b/drivers/crypto/bcm/spu2.c
@@ -302,6 +302,7 @@  static int spu2_hash_mode_xlate(enum hash_mode hash_mode,
 		break;
 	case HASH_ALG_SHA3_512:
 		*spu2_type = SPU2_HASH_TYPE_SHA3_512;
+		break;
 	case HASH_ALG_LAST:
 	default:
 		err = -EINVAL;