| Message ID | 20141122183628.GD6994@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Sat, 2014-11-22 at 21:36 +0300, Dan Carpenter wrote: > This can't be NULL and we dereferenced it earlier. Smatch used to > ignore these things where the pointer was obviously non-NULL but I've > found that sometimes the intention was to check something else so we > were maybe missing bugs. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c > index 99eefd8..a225a5ca 100644 > --- a/arch/x86/crypto/sha-mb/sha1_mb.c > +++ b/arch/x86/crypto/sha-mb/sha1_mb.c > @@ -204,8 +204,7 @@ static struct sha1_hash_ctx *sha1_ctx_mgr_resubmit(struct sha1_ctx_mgr *mgr, str > continue; > } > > - if (ctx) > - ctx->status = HASH_CTX_STS_IDLE; > + ctx->status = HASH_CTX_STS_IDLE; > return ctx; > } > Agree. This NULL pointer check is not necessary. Acked-by: Tim Chen <tim.c.chen@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Nov 22, 2014 at 09:36:28PM +0300, Dan Carpenter wrote: > This can't be NULL and we dereferenced it earlier. Smatch used to > ignore these things where the pointer was obviously non-NULL but I've > found that sometimes the intention was to check something else so we > were maybe missing bugs. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied. Thanks!
diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c index 99eefd8..a225a5ca 100644 --- a/arch/x86/crypto/sha-mb/sha1_mb.c +++ b/arch/x86/crypto/sha-mb/sha1_mb.c @@ -204,8 +204,7 @@ static struct sha1_hash_ctx *sha1_ctx_mgr_resubmit(struct sha1_ctx_mgr *mgr, str continue; } - if (ctx) - ctx->status = HASH_CTX_STS_IDLE; + ctx->status = HASH_CTX_STS_IDLE; return ctx; }
This can't be NULL and we dereferenced it earlier. Smatch used to ignore these things where the pointer was obviously non-NULL but I've found that sometimes the intention was to check something else so we were maybe missing bugs. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html