diff mbox

crypto: cts - Remove bogus use of seqiv

Message ID 20150116070921.GA8992@gondor.apana.org.au (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Herbert Xu Jan. 16, 2015, 7:09 a.m. UTC
The seqiv generator is completely inappropriate for cts as it's
designed for IPsec algorithms.  Since cts users do not actually
use the IV generator we can just fall back to the default.
 
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Maciej Żenczykowski Jan. 16, 2015, 4:53 p.m. UTC | #1
On Thu, Jan 15, 2015 at 11:09 PM, Herbert Xu
<herbert@gondor.apana.org.au> wrote:
> The seqiv generator is completely inappropriate for cts as it's
> designed for IPsec algorithms.  Since cts users do not actually
> use the IV generator we can just fall back to the default.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/crypto/cts.c b/crypto/cts.c
> index bd94058..6a8089c 100644
> --- a/crypto/cts.c
> +++ b/crypto/cts.c
> @@ -307,8 +307,6 @@ static struct crypto_instance *crypto_cts_alloc(struct rtattr **tb)
>         inst->alg.cra_blkcipher.min_keysize = alg->cra_blkcipher.min_keysize;
>         inst->alg.cra_blkcipher.max_keysize = alg->cra_blkcipher.max_keysize;
>
> -       inst->alg.cra_blkcipher.geniv = "seqiv";
> -
>         inst->alg.cra_ctxsize = sizeof(struct crypto_cts_ctx);
>
>         inst->alg.cra_init = crypto_cts_init_tfm;
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Acked-by: Maciej ?enczykowski <zenczykowski@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/crypto/cts.c b/crypto/cts.c
index bd94058..6a8089c 100644
--- a/crypto/cts.c
+++ b/crypto/cts.c
@@ -307,8 +307,6 @@  static struct crypto_instance *crypto_cts_alloc(struct rtattr **tb)
 	inst->alg.cra_blkcipher.min_keysize = alg->cra_blkcipher.min_keysize;
 	inst->alg.cra_blkcipher.max_keysize = alg->cra_blkcipher.max_keysize;
 
-	inst->alg.cra_blkcipher.geniv = "seqiv";
-
 	inst->alg.cra_ctxsize = sizeof(struct crypto_cts_ctx);
 
 	inst->alg.cra_init = crypto_cts_init_tfm;