From patchwork Mon Apr 24 14:16:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 9696473 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E134D601AE for ; Mon, 24 Apr 2017 14:18:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D056427813 for ; Mon, 24 Apr 2017 14:18:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1FD628342; Mon, 24 Apr 2017 14:18:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B79E27813 for ; Mon, 24 Apr 2017 14:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1171891AbdDXOSo (ORCPT ); Mon, 24 Apr 2017 10:18:44 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36075 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1171491AbdDXOSn (ORCPT ); Mon, 24 Apr 2017 10:18:43 -0400 Received: by mail-wr0-f195.google.com with SMTP id v42so12636431wrc.3; Mon, 24 Apr 2017 07:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uKVqcaiQETQzX2AYnpJrrD8fS5ALPhg08Q1KNLU39C0=; b=euOh/ho/DOt0I0WuZj8hJLP7QE/Yx1vmYcJDT9mlXHs4PLYKVjr5VgfvWu5gYR54yk l5PfX/KqcSES4LwMF+PLwqd+7MY8hlHxwKJmaRRaBcHM5VOthv690r+gPdq1bwUUw9IC Us77SgTL+0rCihLTA3W3rFQw3k+5v9CaSOND2RiXjDw4yRfynG65+IWzGZIavFKHZIum 4lIhmmI1khY6Shm8QMvLstuTaZ3GnXX2kIBSVBDt200WQQn0T98AWlCsf/Vsktw5PS2H i8tjZmp8CS3aj8r2HgKp/K0mFGcGRV1FwMqBxiF0CW0rpiVxHuGfp1I8B5O3qFXsLSYW oOSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uKVqcaiQETQzX2AYnpJrrD8fS5ALPhg08Q1KNLU39C0=; b=ZEJ+iU1Exy6LCx3e8jiLbBosOuxOmkal3D7qK0wvGEzSpzHdZCAuhbROImiWgJdpxd h30eDKKIb5cIo+Q83knalwDNWeqLAvgCLsJTbtmuQtRkM5SQa/f6uw6IxuxnEFa6t8rC RsaLbPlRJ3Bkf/eh2NXyBQ6YsziOgZqNOH8morJXOGNrmzkRZv5O9wjBo4Vv1HVFuXAV G2oXEa8wsBS7qCQDCokiiHc/S2u45w1CDCeijrLZzcs/d5qn3kbPi/KrPM2SGMYbO8LZ TcFpMIaFHyaS3uLiZCGWrEGjtJCBMFi9T4Yjb2PVMmKWUkN0OdVz5rak+nlE6pTg6EYh idkw== X-Gm-Message-State: AN3rC/63vd8dmWtnacBquPxpMuY4+Z17YLt2hUMuAJDRufYs5GmBHwmc 4m+K6tUihWRFKw== X-Received: by 10.223.148.7 with SMTP id 7mr6029298wrq.65.1493043521777; Mon, 24 Apr 2017 07:18:41 -0700 (PDT) Received: from Red.local (LFbn-1-7035-57.w90-116.abo.wanadoo.fr. [90.116.208.57]) by smtp.googlemail.com with ESMTPSA id q140sm548033wmb.14.2017.04.24.07.18.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 24 Apr 2017 07:18:41 -0700 (PDT) From: Corentin Labbe To: herbert@gondor.apana.org.au, davem@davemloft.net, thomas.lendacky@amd.com, gary.hook@amd.com, boris.brezillon@free-electrons.com, arno@natisbad.org, matthias.bgg@gmail.com, giovanni.cabiddu@intel.com, salvatore.benedetto@intel.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, qat-linux@intel.com, Corentin Labbe Subject: [PATCH 1/9] crypto: add hmac IPAD/OPAD constant Date: Mon, 24 Apr 2017 16:16:21 +0200 Message-Id: <20170424141629.27155-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.10.2 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Many HMAC users directly use directly 0x36/0x5c values. It's better with crypto to use a name instead of directly some crypto constant. This patch simply add HMAC_IPAD_VALUE/HMAC_OPAD_VALUE defines. Signed-off-by: Corentin Labbe --- crypto/hmac.c | 4 ++-- include/crypto/hash.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crypto/hmac.c b/crypto/hmac.c index 72e38c0..4a997ce 100644 --- a/crypto/hmac.c +++ b/crypto/hmac.c @@ -74,8 +74,8 @@ static int hmac_setkey(struct crypto_shash *parent, memcpy(opad, ipad, bs); for (i = 0; i < bs; i++) { - ipad[i] ^= 0x36; - opad[i] ^= 0x5c; + ipad[i] ^= HMAC_IPAD_VALUE; + opad[i] ^= HMAC_OPAD_VALUE; } return crypto_shash_init(shash) ?: diff --git a/include/crypto/hash.h b/include/crypto/hash.h index b5727bc..0f51ff1 100644 --- a/include/crypto/hash.h +++ b/include/crypto/hash.h @@ -922,4 +922,7 @@ static inline void shash_desc_zero(struct shash_desc *desc) sizeof(*desc) + crypto_shash_descsize(desc->tfm)); } +#define HMAC_IPAD_VALUE 0x36 +#define HMAC_OPAD_VALUE 0x5c + #endif /* _CRYPTO_HASH_H */