From patchwork Sun May 20 05:07:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Biggers X-Patchwork-Id: 10413087 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BB91860353 for ; Sun, 20 May 2018 05:07:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACA19286FE for ; Sun, 20 May 2018 05:07:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A178C28707; Sun, 20 May 2018 05:07:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BD932847A for ; Sun, 20 May 2018 05:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751029AbeETFHD (ORCPT ); Sun, 20 May 2018 01:07:03 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:42570 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbeETFHA (ORCPT ); Sun, 20 May 2018 01:07:00 -0400 Received: by mail-pl0-f66.google.com with SMTP id u6-v6so6860446pls.9 for ; Sat, 19 May 2018 22:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fLHRVvyNupq99XhyuMNGrFiw5PhGgcMs8bebzxbb8rA=; b=A/UiJPkEbZAkMyoebBFsZSjGV0Cw/lrOlm9vCAQxYpIS4FCGZeq9Icy8BkPBeyzwlA eAOvduY4cbP1vpVQP2sCVR6TEN69HfbBKkoSDqIFQja1DiZ3e458/k/qSO9kMw9bXcpG Q1KACYuMH0hECEvO+FvDTVzBXGbJPBlHrwftKWfZ2luFfUD883XoUVuqHnzm46rsOpPI DKuPAZVve3g/Zes7+AA1AVgkj9dtO9ZwDajAc1TohM44FsmY5syC4fugCjl2SgZCoqpb xOORlRkqaXzOTy3CR+esSXMdCC1HWOXmAumUpw/05lId9IAn7XFglDSob/7t8WbSjku+ jYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fLHRVvyNupq99XhyuMNGrFiw5PhGgcMs8bebzxbb8rA=; b=iFj9iG8Ly1g/hesdqZWF2XihQWXAJTFC+SuvxRpjEfFqLyxgd2s+EEjkDokuNcwuFz w08zj3w/S0x+60CfvRkUjbhurMtd4HT/hq/N3JhBP5gR+Cuxj+T58DCOWp9aQtsK85kb CATkwZH9YHScBjxGn4lAKkvy/C2G7RX16ddEqFuqROvsTDX+POusvjspzsawme1wtZFn HddyPp452pen3ZOuiWSAXOPDosoOgMZr1zwyIKUcLGOteb/fKB/bKRAooEnTD5wpGBSI ETknxJ04Nwxuy1NIiZviCQRaQeVykLGA5ilCNcKq3r39k2Flai5Bgr5WLtw2qW/mJ8VM 2hzQ== X-Gm-Message-State: ALKqPweRQs8dREWMptvcgq22TjBYg1z/+205BWhIBGHhEuIWI5Cfl/sU 9XbvSSzPm/vLKACOwRzMgHDEXmMj X-Google-Smtp-Source: AB8JxZqf8JyzfbT6nYiUjR/PeKZloduKC5nZUoKqDXdzLGkQYIcv7jkV2liNBCU8TBGPd+P1TfcONA== X-Received: by 2002:a17:902:10c:: with SMTP id 12-v6mr15792132plb.252.1526792819705; Sat, 19 May 2018 22:06:59 -0700 (PDT) Received: from sol.localdomain (c-67-185-97-198.hsd1.wa.comcast.net. [67.185.97.198]) by smtp.gmail.com with ESMTPSA id m9-v6sm19488322pff.41.2018.05.19.22.06.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 22:06:59 -0700 (PDT) From: Eric Biggers To: linux-crypto@vger.kernel.org, Herbert Xu Cc: Eric Biggers Subject: [PATCH 4/6] crypto: testmgr - remove bfin_crc "hmac(crc32)" test vectors Date: Sat, 19 May 2018 22:07:40 -0700 Message-Id: <20180520050742.5008-5-ebiggers3@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180520050742.5008-1-ebiggers3@gmail.com> References: <20180520050742.5008-1-ebiggers3@gmail.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Eric Biggers The Blackfin CRC driver was removed by commit 9678a8dc53c1 ("crypto: bfin_crc - remove blackfin CRC driver"), but it was forgotten to remove the corresponding "hmac(crc32)" test vectors. I see no point in keeping them since nothing else appears to implement or use "hmac(crc32)", which isn't an algorithm that makes sense anyway because HMAC is meant to be used with a cryptographically secure hash function, which CRC's are not. Thus, remove the unneeded test vectors. Signed-off-by: Eric Biggers --- crypto/tcrypt.c | 4 --- crypto/testmgr.c | 6 ---- crypto/testmgr.h | 88 ------------------------------------------------ 3 files changed, 98 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index e721faab6fc8..d5bcdd905007 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -1942,10 +1942,6 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) ret += tcrypt_test("vmac(aes)"); break; - case 110: - ret += tcrypt_test("hmac(crc32)"); - break; - case 111: ret += tcrypt_test("hmac(sha3-224)"); break; diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 41a5f42d4104..7e57530ecd52 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -3168,12 +3168,6 @@ static const struct alg_test_desc alg_test_descs[] = { .suite = { .hash = __VECS(ghash_tv_template) } - }, { - .alg = "hmac(crc32)", - .test = alg_test_hash, - .suite = { - .hash = __VECS(bfin_crc_tv_template) - } }, { .alg = "hmac(md5)", .test = alg_test_hash, diff --git a/crypto/testmgr.h b/crypto/testmgr.h index 552d8f00d85b..816e3eb197b2 100644 --- a/crypto/testmgr.h +++ b/crypto/testmgr.h @@ -43156,94 +43156,6 @@ static const struct hash_testvec crc32c_tv_template[] = { } }; -/* - * Blakcifn CRC test vectors - */ -static const struct hash_testvec bfin_crc_tv_template[] = { - { - .psize = 0, - .digest = "\x00\x00\x00\x00", - }, - { - .key = "\x87\xa9\xcb\xed", - .ksize = 4, - .psize = 0, - .digest = "\x87\xa9\xcb\xed", - }, - { - .key = "\xff\xff\xff\xff", - .ksize = 4, - .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08" - "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10" - "\x11\x12\x13\x14\x15\x16\x17\x18" - "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20" - "\x21\x22\x23\x24\x25\x26\x27\x28", - .psize = 40, - .digest = "\x84\x0c\x8d\xa2", - }, - { - .key = "\xff\xff\xff\xff", - .ksize = 4, - .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08" - "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10" - "\x11\x12\x13\x14\x15\x16\x17\x18" - "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20" - "\x21\x22\x23\x24\x25\x26", - .psize = 38, - .digest = "\x8c\x58\xec\xb7", - }, - { - .key = "\xff\xff\xff\xff", - .ksize = 4, - .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08" - "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10" - "\x11\x12\x13\x14\x15\x16\x17\x18" - "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20" - "\x21\x22\x23\x24\x25\x26\x27", - .psize = 39, - .digest = "\xdc\x50\x28\x7b", - }, - { - .key = "\xff\xff\xff\xff", - .ksize = 4, - .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08" - "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10" - "\x11\x12\x13\x14\x15\x16\x17\x18" - "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20" - "\x21\x22\x23\x24\x25\x26\x27\x28" - "\x29\x2a\x2b\x2c\x2d\x2e\x2f\x30" - "\x31\x32\x33\x34\x35\x36\x37\x38" - "\x39\x3a\x3b\x3c\x3d\x3e\x3f\x40" - "\x41\x42\x43\x44\x45\x46\x47\x48" - "\x49\x4a\x4b\x4c\x4d\x4e\x4f\x50" - "\x51\x52\x53\x54\x55\x56\x57\x58" - "\x59\x5a\x5b\x5c\x5d\x5e\x5f\x60" - "\x61\x62\x63\x64\x65\x66\x67\x68" - "\x69\x6a\x6b\x6c\x6d\x6e\x6f\x70" - "\x71\x72\x73\x74\x75\x76\x77\x78" - "\x79\x7a\x7b\x7c\x7d\x7e\x7f\x80" - "\x81\x82\x83\x84\x85\x86\x87\x88" - "\x89\x8a\x8b\x8c\x8d\x8e\x8f\x90" - "\x91\x92\x93\x94\x95\x96\x97\x98" - "\x99\x9a\x9b\x9c\x9d\x9e\x9f\xa0" - "\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8" - "\xa9\xaa\xab\xac\xad\xae\xaf\xb0" - "\xb1\xb2\xb3\xb4\xb5\xb6\xb7\xb8" - "\xb9\xba\xbb\xbc\xbd\xbe\xbf\xc0" - "\xc1\xc2\xc3\xc4\xc5\xc6\xc7\xc8" - "\xc9\xca\xcb\xcc\xcd\xce\xcf\xd0" - "\xd1\xd2\xd3\xd4\xd5\xd6\xd7\xd8" - "\xd9\xda\xdb\xdc\xdd\xde\xdf\xe0" - "\xe1\xe2\xe3\xe4\xe5\xe6\xe7\xe8" - "\xe9\xea\xeb\xec\xed\xee\xef\xf0", - .psize = 240, - .digest = "\x10\x19\x4a\x5c", - .np = 2, - .tap = { 31, 209 } - }, - -}; - static const struct comp_testvec lz4_comp_tv_template[] = { { .inlen = 255,